change metric_value to model_name

Author: peterdudfield

nowcasting_datamodel/migrations/forecast/versions/caea7b5cf249_.py

@@ -0,0 +1,40 @@
+"""
+
+Switch to use metric_value.model_name instead of metric_value.model_id
+
+Revision ID: caea7b5cf249
+Revises: 37c68fd8e65c
+Create Date: 2023-04-14 15:45:13.418891
+
+"""
+import sqlalchemy as sa
+from alembic import op
+
+# revision identifiers, used by Alembic.
+revision = "caea7b5cf249"
+down_revision = "37c68fd8e65c"
+branch_labels = None
+depends_on = None
+
+
+def upgrade():  # noqa
+    # ### commands auto generated by Alembic - please adjust! ###
+
+    op.add_column("metric_value", sa.Column("model_name", sa.String(), nullable=True))
+    op.drop_index("ix_metric_value_model_id", table_name="metric_value")
+    op.drop_constraint("metric_value_model_id_fkey", "metric_value", type_="foreignkey")
+    op.drop_column("metric_value", "model_id")
+    # ### end Alembic commands ###
+
+
+def downgrade():  # noqa
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.add_column(
+        "metric_value", sa.Column("model_id", sa.INTEGER(), autoincrement=False, nullable=True)
+    )
+    op.create_foreign_key(
+        "metric_value_model_id_fkey", "metric_value", "model", ["model_id"], ["id"]
+    )
+    op.create_index("ix_metric_value_model_id", "metric_value", ["model_id"], unique=False)
+    op.drop_column("metric_value", "model_name")
+    # ### end Alembic commands ###

nowcasting_datamodel/models/metric.py

@@ -132,6 +132,7 @@ class MetricValueSQL(Base_Forecast, CreatedMixin):
     number_of_data_points = Column(Integer, nullable=False)
     forecast_horizon_minutes = Column(Integer, nullable=True)
     time_of_day = Column(Time, nullable=True)
+    model_name = Column(String, nullable=True)
 
     # many (metric values) to one (metric)
     metric = relationship("MetricSQL", back_populates="metric_value")
@@ -145,9 +146,7 @@ class MetricValueSQL(Base_Forecast, CreatedMixin):
     datetime_interval = relationship("DatetimeIntervalSQL", back_populates="metric_value")
     datetime_interval_id = Column(Integer, ForeignKey("datetime_interval.id"), index=True)
 
-    # many (metric values) to one (model)
-    model = relationship("MLModelSQL", back_populates="metric_value")
-    model_id = Column(Integer, ForeignKey("model.id"), index=True)
+
 
 
 class MetricValue(EnhancedBaseModel):