add comments

Author: peterdudfield

nowcasting_datamodel/models/convert.py

@@ -103,6 +103,10 @@ def convert_df_to_national_forecast(
         if "forecast_mw_plevel_10" in forecast_values_df.columns:
             forecast_value_sql.properties = {
                 "10": forecast_value.forecast_mw_plevel_10,
+            }
+
+        if "forecast_mw_plevel_90" in forecast_values_df.columns:
+            forecast_value_sql.properties = {
                 "90": forecast_value.forecast_mw_plevel_90,
             }
 

nowcasting_datamodel/models/forecast.py

@@ -318,6 +318,8 @@ class ForecastValue(EnhancedBaseModel):
         "The _ at the start means it is not expose in the API",
     )
 
+    # This its better to keep this out of the current pydantic models used by the API.
+    # A new pydantic mode can be made that includes the forecast plevels, perhaps in the API.
     _properties: dict = Field(
         None,
         description="Dictionary to hold properties of the forecast, like p_levels. "