2 fixes (#174)

* dont drop model_id in metric_value column

* add extra commit

Author: peterdudfield

nowcasting_datamodel/migrations/forecast/versions/caea7b5cf249_.py

@@ -21,20 +21,10 @@ def upgrade():  # noqa
     # ### commands auto generated by Alembic - please adjust! ###
 
     op.add_column("metric_value", sa.Column("model_name", sa.String(), nullable=True))
-    op.drop_index("ix_metric_value_model_id", table_name="metric_value")
-    op.drop_constraint("metric_value_model_id_fkey", "metric_value", type_="foreignkey")
-    op.drop_column("metric_value", "model_id")
     # ### end Alembic commands ###
 
 
 def downgrade():  # noqa
     # ### commands auto generated by Alembic - please adjust! ###
-    op.add_column(
-        "metric_value", sa.Column("model_id", sa.INTEGER(), autoincrement=False, nullable=True)
-    )
-    op.create_foreign_key(
-        "metric_value_model_id_fkey", "metric_value", "model", ["model_id"], ["id"]
-    )
-    op.create_index("ix_metric_value_model_id", "metric_value", ["model_id"], unique=False)
     op.drop_column("metric_value", "model_name")
     # ### end Alembic commands ###

nowcasting_datamodel/save/update.py

@@ -80,6 +80,7 @@ def upsert(session: Session, model, rows: List[dict]):
 
     stmt = stmt.on_conflict_do_update(index_elements=primary_keys, set_=update_dict)
     session.execute(stmt, rows)
+    session.commit()
 
 
 def update_forecast_latest(