Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

Commit a0688dc

Browse files
committed
Remove sample period duration
This is already done in the other IterDataPipe, so keeping functionality there
1 parent c5bb35e commit a0688dc

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

ocf_datapipes/load/pv.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,14 @@ def __init__(
2121
self,
2222
pv_power_filename: Union[str, Path],
2323
pv_metadata_filename: Union[str, Path],
24-
sample_period_duration: datetime.timedelta = datetime.timedelta(minutes=5),
2524
):
2625
super().__init__()
2726
self.pv_power_filename = pv_power_filename
2827
self.pv_metadata_filename = pv_metadata_filename
29-
self.sample_period_duration = sample_period_duration
3028

3129
def __iter__(self):
3230
data: xr.DataArray = load_everything_into_ram(
33-
self.pv_power_filename, self.pv_metadata_filename, self.sample_period_duration
31+
self.pv_power_filename, self.pv_metadata_filename
3432
)
3533
while True:
3634
yield data
@@ -46,7 +44,7 @@ def __iter__(self):
4644

4745

4846
def load_everything_into_ram(
49-
pv_power_filename, pv_metadata_filename, sample_period_duration
47+
pv_power_filename, pv_metadata_filename
5048
) -> xr.DataArray:
5149
"""Open AND load PV data into RAM."""
5250
# Load pd.DataFrame of power and pd.Series of capacities:
@@ -66,7 +64,6 @@ def load_everything_into_ram(
6664
x_osgb=pv_metadata.x_osgb.astype(np.float32),
6765
capacity_wp=pv_capacity_wp,
6866
pv_system_row_number=pv_system_row_number,
69-
sample_period_duration=sample_period_duration,
7067
)
7168

7269
# Sanity checks:
@@ -251,7 +248,6 @@ def _put_pv_data_into_an_xr_dataarray(
251248
x_osgb: pd.Series,
252249
capacity_wp: pd.Series,
253250
pv_system_row_number: pd.Series,
254-
sample_period_duration: datetime.timedelta,
255251
) -> xr.DataArray:
256252
"""Convert to an xarray DataArray.
257253
@@ -283,7 +279,6 @@ def _put_pv_data_into_an_xr_dataarray(
283279
)
284280
# Sample period duration is required so PVDownsample transform knows by how much
285281
# to change the pv_t0_idx:
286-
data_array.attrs["sample_period_duration"] = sample_period_duration
287282
return data_array
288283

289284

0 commit comments

Comments
 (0)