Skip to content

Commit 611c80c

Browse files
jhovoldWen Zhiwei
authored andcommitted
pinctrl: qcom: spmi: fix debugfs drive strength
stable inclusion from stable-v6.6.64 commit 6a4645bc3b14e027cea1e8f5d0df02efa7fc23b3 category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/IBL4B6 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=6a4645bc3b14e027cea1e8f5d0df02efa7fc23b3 -------------------------------- commit 6bc0ebfb1d920f13c522545f114cdabb49e9408a upstream. Commit 723e846 ("pinctrl: qcom: spmi-gpio: Fix the GPIO strength mapping") fixed a long-standing issue in the Qualcomm SPMI PMIC gpio driver which had the 'low' and 'high' drive strength settings switched but failed to update the debugfs interface which still gets this wrong. Fix the debugfs code so that the exported values match the hardware settings. Note that this probably means that most devicetrees that try to describe the firmware settings got this wrong if the settings were derived from debugfs. Before the above mentioned commit the settings would have actually matched the firmware settings even if they were described incorrectly, but now they are inverted. Fixes: 723e846 ("pinctrl: qcom: spmi-gpio: Fix the GPIO strength mapping") Fixes: eadff30 ("pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver") Cc: Anjelique Melendez <[email protected]> Cc: [email protected] # 3.19 Signed-off-by: Johan Hovold <[email protected]> Reviewed-by: Konrad Dybcio <[email protected]> Link: https://lore.kernel.org/[email protected] Signed-off-by: Linus Walleij <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Wen Zhiwei <[email protected]>
1 parent 80f99c5 commit 611c80c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/pinctrl/qcom/pinctrl-spmi-gpio.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -667,7 +667,7 @@ static void pmic_gpio_config_dbg_show(struct pinctrl_dev *pctldev,
667667
"push-pull", "open-drain", "open-source"
668668
};
669669
static const char *const strengths[] = {
670-
"no", "high", "medium", "low"
670+
"no", "low", "medium", "high"
671671
};
672672

673673
pad = pctldev->desc->pins[pin].drv_data;

0 commit comments

Comments
 (0)