firewire: cdev: fix another memory leak in an error path

Stefan Richter · Stefan Richter · commit cf0e575dcc4c · 2009-12-29T19:58:16.000+01:00
If copy_from_user in an FW_CDEV_IOC_SEND_RESPONSE ioctl failed, the
fw_request pointed to by the inbound_transaction_resource is no
longer referenced and needs to be freed.

Signed-off-by: Stefan Richter &lt;stefanr@s5r6.in-berlin.de&gt;
diff --git a/drivers/firewire/core-cdev.c b/drivers/firewire/core-cdev.c
@@ -723,6 +723,7 @@ static int ioctl_send_response(struct client *client, void *buffer)
 		if (copy_from_user(r->data, u64_to_uptr(request->data),
 				   r->length)) {
 			ret = -EFAULT;
+			kfree(r->request);
 			goto out;
 		}
 		fw_send_response(client->device->card, r->request,

Original file line number	Diff line number	Diff line change
`@@ -723,6 +723,7 @@ static int ioctl_send_response(struct client client, void buffer)`
`723`	`723`	`if (copy_from_user(r->data, u64_to_uptr(request->data),`
`724`	`724`	`r->length)) {`
`725`	`725`	`ret = -EFAULT;`
	`726`	`+ kfree(r->request);`
`726`	`727`	`goto out;`
`727`	`728`	`}`
`728`	`729`	`fw_send_response(client->device->card, r->request,`