deploy: use Recreate strategy for Deployments (#3133)

stevekuznetsov · ci-robot · commit 3803405d131c · 2023-12-18T19:05:13.000Z
Our controllers must not share runtime with controllers of previous
versions, as we expect that the set of actors on the cluster to be
coherent with respect to what they're trying to do. RollingUpdate
strategies do not guarantee this and lead to cases where previous
versions of the operators issue spurious mutating calls that the
current operator needs to un-do.

Signed-off-by: Steve Kuznetsov &lt;skuznets@redhat.com&gt;
Upstream-repository: operator-lifecycle-manager
Upstream-commit: cee062283539d08f25333bfa53b2963725e35914
diff --git a/manifests/0000_50_olm_07-olm-operator.deployment.ibm-cloud-managed.yaml b/manifests/0000_50_olm_07-olm-operator.deployment.ibm-cloud-managed.yaml
@@ -10,7 +10,7 @@ metadata:
     capability.openshift.io/name: "OperatorLifecycleManager"
 spec:
   strategy:
-    type: RollingUpdate
+    type: Recreate
   replicas: 1
   selector:
     matchLabels:
diff --git a/manifests/0000_50_olm_07-olm-operator.deployment.yaml b/manifests/0000_50_olm_07-olm-operator.deployment.yaml
@@ -10,7 +10,7 @@ metadata:
     capability.openshift.io/name: "OperatorLifecycleManager"
 spec:
   strategy:
-    type: RollingUpdate
+    type: Recreate
   replicas: 1
   selector:
     matchLabels:
diff --git a/manifests/0000_50_olm_08-catalog-operator.deployment.ibm-cloud-managed.yaml b/manifests/0000_50_olm_08-catalog-operator.deployment.ibm-cloud-managed.yaml
@@ -10,7 +10,7 @@ metadata:
     capability.openshift.io/name: "OperatorLifecycleManager"
 spec:
   strategy:
-    type: RollingUpdate
+    type: Recreate
   replicas: 1
   selector:
     matchLabels:
diff --git a/manifests/0000_50_olm_08-catalog-operator.deployment.yaml b/manifests/0000_50_olm_08-catalog-operator.deployment.yaml
@@ -10,7 +10,7 @@ metadata:
     capability.openshift.io/name: "OperatorLifecycleManager"
 spec:
   strategy:
-    type: RollingUpdate
+    type: Recreate
   replicas: 1
   selector:
     matchLabels:
diff --git a/staging/operator-lifecycle-manager/deploy/chart/templates/0000_50_olm_07-olm-operator.deployment.yaml b/staging/operator-lifecycle-manager/deploy/chart/templates/0000_50_olm_07-olm-operator.deployment.yaml
@@ -7,7 +7,7 @@ metadata:
     app: olm-operator
 spec:
   strategy:
-    type: RollingUpdate
+    type: Recreate
   replicas: {{ .Values.olm.replicaCount }}
   selector:
     matchLabels:
diff --git a/staging/operator-lifecycle-manager/deploy/chart/templates/0000_50_olm_08-catalog-operator.deployment.yaml b/staging/operator-lifecycle-manager/deploy/chart/templates/0000_50_olm_08-catalog-operator.deployment.yaml
@@ -7,7 +7,7 @@ metadata:
     app: catalog-operator
 spec:
   strategy:
-    type: RollingUpdate
+    type: Recreate
   replicas: {{ .Values.catalog.replicaCount }}
   selector:
     matchLabels:
