Skip to content

Kube 1.16 #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Kube 1.16 #400

wants to merge 5 commits into from

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Sep 30, 2019

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 30, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign enxebre
You can assign the PR to them by writing /assign @enxebre in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@enxebre: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/govet 3d1024f link /test govet
ci/prow/images 3d1024f link /test images
ci/prow/e2e-azure-operator 3d1024f link /test e2e-azure-operator
ci/prow/e2e-aws-scaleup-rhel7 3d1024f link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-aws 3d1024f link /test e2e-aws
ci/prow/e2e-aws-upgrade 3d1024f link /test e2e-aws-upgrade
ci/prow/e2e-aws-operator 3d1024f link /test e2e-aws-operator
ci/prow/unit 3d1024f link /test unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ironcladlou
Copy link

P.S., my team got ahead of this by temporarily relying on the Go modules replace directive to depend on the upstream 1.16 PR fork. See ingress-operator for an example.

Seems safe enough to use on our master branch for a while.

@enxebre
Copy link
Member Author

enxebre commented Oct 2, 2019

thanks @ironcladlou we also created kubernetes-sigs/controller-runtime#618 which we are using here openshift/cluster-api#76

@ironcladlou
Copy link

@enxebre

thanks @ironcladlou we also created kubernetes-sigs/controller-runtime#618 which we are using here openshift/cluster-api#76

Cool, thanks! Hopefully one of them gets in soon!

@enxebre
Copy link
Member Author

enxebre commented Oct 3, 2019

closing in favour of #401

@enxebre enxebre closed this Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frobware frobware Awaiting requested review from frobware

@spangenberg spangenberg Awaiting requested review from spangenberg

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enxebre @openshift-ci-robot @ironcladlou