Skip to content

Drop strategy field in favour of annotation #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Oct 17, 2019

There's only two potential use case strategies today: delete and reboot.
Reboot is not yet supported at the machine API level but is rather a baremetal specific process.
Delete is not a good fit on baremetal.
As there's no specific strong use case or clear path forward yet for strategies reusable across multiple environments we don't want to bake this in the API just yet. Instead we are adding an annotation for the strategy on the MHC that can be leveraged for plugin strategies.

  • Introduce healthchecking.openshift.io/strategy annotation
  • Drop spec.RemediationStrategy

Needs #414

@enxebre enxebre changed the title Drop strategy field Drop strategy field in favour of annotation Oct 17, 2019
@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 17, 2019
@enxebre
Copy link
Member Author

enxebre commented Oct 17, 2019

/retest

4 similar comments
@enxebre
Copy link
Member Author

enxebre commented Oct 17, 2019

/retest

@enxebre
Copy link
Member Author

enxebre commented Oct 17, 2019

/retest

@enxebre
Copy link
Member Author

enxebre commented Oct 17, 2019

/retest

@enxebre
Copy link
Member Author

enxebre commented Oct 17, 2019

/retest

@enxebre enxebre force-pushed the drop-strategy-field branch from 686c463 to af17784 Compare October 18, 2019 08:39
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 18, 2019
@openshift-ci-robot
Copy link
Contributor

@enxebre: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 af17784 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Member Author

enxebre commented Oct 18, 2019

This is a follow up for #414
I'm fast merging this to enable farther development and put up the PR for:
Remove feature gate #416

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2019
@enxebre enxebre merged commit 98f86d5 into openshift:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants