-
Notifications
You must be signed in to change notification settings - Fork 216
Drop strategy field in favour of annotation #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
686c463
to
af17784
Compare
@enxebre: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There's only two potential use case strategies today: delete and reboot.
Reboot is not yet supported at the machine API level but is rather a baremetal specific process.
Delete is not a good fit on baremetal.
As there's no specific strong use case or clear path forward yet for strategies reusable across multiple environments we don't want to bake this in the API just yet. Instead we are adding an annotation for the strategy on the MHC that can be leveraged for plugin strategies.
healthchecking.openshift.io/strategy
annotationspec.RemediationStrategy
Needs #414