Revendor controller runtime #426
Conversation
We were pointing to a dead commit of a fork with kube 1.16. We can now point back to canonical repo now this is merged kubernetes-sigs/controller-runtime#618
openshift-ci-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@enxebre: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -58,5 +57,4 @@ replace k8s.io/client-go => github.com/openshift/kubernetes-client-go v0.0.0-201 | |||
|
|
|||
| replace k8s.io/kube-aggregator => github.com/openshift/kubernetes-kube-aggregator v0.0.0-20190918161219-8c8f079fddc3 | |||
|
|
|||
| // https://github.com/kubernetes-sigs/controller-runtime/pull/618 | |||
| replace sigs.k8s.io/controller-runtime => github.com/enxebre/controller-runtime v0.2.0-beta.1.0.20190930160522-58015f7fc885 | |||
| replace sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.3.1-0.20191016212439-2df793d02076 | |||
There was a problem hiding this comment.
Do we still require the replace directive here since we're not really replacing the source? I think this can probably go in the required section instead?
There was a problem hiding this comment.
closed by accident, reopened here #430
We were pointing to a dead commit of a fork with kube 1.16. We can now point back to canonical repo since this is merged kubernetes-sigs/controller-runtime#618