pkg/controller: Migrate to using a read lock instead of a readwrite lock when checking for any namespace caching errors (#2382)

Signed-off-by: timflannagan <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 396b5461555c2498507b1fff20fccc3e7ae15420

Author: timflannagan

staging/operator-lifecycle-manager/pkg/controller/registry/resolver/cache/cache.go

@@ -136,9 +136,9 @@ type NamespacedOperatorCache struct {
 func (c *NamespacedOperatorCache) Error() error {
 	var errs []error
 	for key, snapshot := range c.snapshots {
-		snapshot.m.Lock()
+		snapshot.m.RLock()
 		err := snapshot.err
-		snapshot.m.Unlock()
+		snapshot.m.RUnlock()
 		if err != nil {
 			errs = append(errs, fmt.Errorf("error using catalog %s (in namespace %s): %w", key.Name, key.Namespace, err))
 		}