add missing pod disruption reasons to isPodDead (#3519)

isPodDead had checks for TerminationByKubelet and DeletionByTaintManager.
It was missing checks for

PreemptionByScheduler
EvictionByEvictionAPI
DeletionByPodGC

ref: https://kubernetes.io/docs/concepts/workloads/pods/disruptions/#pod-disruption-conditions

This PR adds those reasons.

Signed-off-by: Anik Bhattacharjee <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 59bfe7f2225dd96ca5690157ebb5d0dc7ac654f9

Author: anik120

staging/operator-lifecycle-manager/pkg/controller/registry/reconciler/grpc.go

@@ -528,37 +528,12 @@ func imageChanged(logger *logrus.Entry, updatePod *corev1.Pod, servingPods []*co
 	return false
 }
 
+// isPodDead checks if the pod has the DisruptionTarget condition set to true,
+// which indicates that the Pod is about to be deleted due to a disruption.
+// ref: https://kubernetes.io/docs/concepts/workloads/pods/disruptions/#pod-disruption-conditions
 func isPodDead(pod *corev1.Pod) bool {
-	for _, check := range []func(*corev1.Pod) bool{
-		isPodDeletedByTaintManager,
-		isPodTerminatedByKubelet,
-	} {
-		if check(pod) {
-			return true
-		}
-	}
-	return false
-}
-
-func isPodDeletedByTaintManager(pod *corev1.Pod) bool {
-	if pod.DeletionTimestamp == nil {
-		return false
-	}
-	for _, condition := range pod.Status.Conditions {
-		if condition.Type == corev1.DisruptionTarget && condition.Reason == "DeletionByTaintManager" && condition.Status == corev1.ConditionTrue {
-			return true
-		}
-	}
-	return false
-}
-
-// This reason is set when the Pod was evicted due to resource pressure on the Node
-func isPodTerminatedByKubelet(pod *corev1.Pod) bool {
-	if pod.DeletionTimestamp == nil {
-		return false
-	}
 	for _, condition := range pod.Status.Conditions {
-		if condition.Type == corev1.DisruptionTarget && condition.Reason == "TerminationByKubelet" && condition.Status == corev1.ConditionTrue {
+		if condition.Type == corev1.DisruptionTarget && condition.Status == corev1.ConditionTrue {
 			return true
 		}
 	}