make removing non-exist package error (#779)

Signed-off-by: akihikokuroda <[email protected]>

Upstream-repository: operator-registry
Upstream-commit: 5566e4b6832a7fc08c12d3c79fc0a0b8c6a2e7aa

Author: akihikokuroda

staging/operator-registry/pkg/sqlite/load.go

@@ -957,6 +957,9 @@ func (s *sqlLoader) RemovePackage(packageName string) error {
 		if err != nil {
 			return err
 		}
+		if len(csvNames) == 0 {
+			return fmt.Errorf("no package found for packagename %s", packageName)
+		}
 		for _, csvName := range csvNames {
 			if err := s.rmBundle(tx, csvName); err != nil {
 				return err

staging/operator-registry/pkg/sqlite/remove_test.go

@@ -76,6 +76,10 @@ func TestRemover(t *testing.T) {
 	_, err = query.GetPackage(context.TODO(), "prometheus")
 	require.EqualError(t, err, "package prometheus not found")
 
+	// delete prometheus again
+	err = store.RemovePackage("prometheus")
+	require.EqualError(t, err, "no package found for packagename prometheus")
+
 	// no apis after all packages are removed
 	rows, err = db.QueryContext(context.TODO(), "select * from api")
 	require.NoError(t, err)