Skip to content

Commit 6d39cbf

Browse files
committed
OCPBUGS-8993: add namespace label to InstallPlanStepAppliedWithWarnings (#3012)
The alerting consistency guide [1] requires the following: `Alerts SHOULD include a namespace label indicating the alert's source.` This change updates the expression of InstallPlanStepAppliedWithWarnings to aggregate the result by namespace. [1] https://github.com/openshift/enhancements/blob/master/enhancements/monitoring/alerting-consistency.md Signed-off-by: Simon Pasquier <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: 2976198c8e22837af8b7ade704212a536fa37071
1 parent 872e6f5 commit 6d39cbf

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

manifests/0000_90_olm_01-prometheus-rule.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ spec:
3636
- name: olm.installplan.rules
3737
rules:
3838
- alert: InstallPlanStepAppliedWithWarnings
39-
expr: sum(increase(installplan_warnings_total[5m])) > 0
39+
expr: sum by(namespace) (increase(installplan_warnings_total[5m])) > 0
4040
labels:
4141
severity: warning
4242
annotations:

staging/operator-lifecycle-manager/deploy/chart/templates/0000_90_olm_01-prometheus-rule.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ spec:
3434
- name: olm.installplan.rules
3535
rules:
3636
- alert: InstallPlanStepAppliedWithWarnings
37-
expr: sum(increase(installplan_warnings_total[5m])) > 0
37+
expr: sum by(namespace) (increase(installplan_warnings_total[5m])) > 0
3838
labels:
3939
severity: warning
4040
annotations:

0 commit comments

Comments
 (0)