fixing reliance on candidate channel containing all referenced bundles (#1009)

Signed-off-by: Jordan Keister <[email protected]>
Upstream-commit: 52e35f0291529290363e0e2d23d5b0c1524103c1
Upstream-repository: operator-registry

Author: grokspawn

staging/operator-registry/alpha/veneer/semver/semver.go

@@ -84,10 +84,16 @@ func (v Veneer) Render(ctx context.Context) (*declcfg.DeclarativeConfig, error)
 	}
 
 	var cfgs []declcfg.DeclarativeConfig
-	for _, b := range sv.Candidate.Bundles {
+
+	bundleDict := make(map[string]struct{})
+	buildBundleList(&sv.Candidate.Bundles, &bundleDict)
+	buildBundleList(&sv.Fast.Bundles, &bundleDict)
+	buildBundleList(&sv.Stable.Bundles, &bundleDict)
+
+	for b, _ := range bundleDict {
 		r := action.Render{
 			AllowedRefMask: action.RefBundleImage,
-			Refs:           []string{b.Image},
+			Refs:           []string{b},
 			Registry:       v.Registry,
 		}
 		c, err := r.Run(ctx)
@@ -114,6 +120,14 @@ func (v Veneer) Render(ctx context.Context) (*declcfg.DeclarativeConfig, error)
 	return &out, nil
 }
 
+func buildBundleList(bundles *[]semverVeneerBundleEntry, dict *map[string]struct{}) {
+	for _, b := range *bundles {
+		if _, ok := (*dict)[b.Image]; !ok {
+			(*dict)[b.Image] = struct{}{}
+		}
+	}
+}
+
 func readFile(data io.Reader) (*semverVeneer, error) {
 	fileData, err := io.ReadAll(data)
 	if err != nil {