Skip to content

Commit c0a7c2e

Browse files
committed
Remove grace period from csv deletions
Signed-off-by: perdasilva <[email protected]>
1 parent d795a1d commit c0a7c2e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

staging/operator-lifecycle-manager/pkg/api/wrappers/deployment_install_client.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,8 @@ func (c *InstallStrategyDeploymentClientForNamespace) CreateDeployment(deploymen
104104
func (c *InstallStrategyDeploymentClientForNamespace) DeleteDeployment(name string) error {
105105
foregroundDelete := metav1.DeletePropagationForeground // cascading delete
106106
// Note(tflannag): See https://bugzilla.redhat.com/show_bug.cgi?id=1939294.
107-
immediate := int64(1)
108-
immediateForegroundDelete := &metav1.DeleteOptions{GracePeriodSeconds: &immediate, PropagationPolicy: &foregroundDelete}
107+
// immediate := int64(1)
108+
immediateForegroundDelete := &metav1.DeleteOptions{GracePeriodSeconds: nil, PropagationPolicy: &foregroundDelete}
109109
return c.opClient.DeleteDeployment(c.Namespace, name, immediateForegroundDelete)
110110
}
111111

staging/operator-lifecycle-manager/pkg/controller/operators/olm/operator.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1154,7 +1154,7 @@ func (a *Operator) removeDanglingChildCSVs(csv *v1alpha1.ClusterServiceVersion)
11541154

11551155
func (a *Operator) deleteChild(csv *v1alpha1.ClusterServiceVersion, logger *logrus.Entry) error {
11561156
logger.Debug("gcing csv")
1157-
return a.client.OperatorsV1alpha1().ClusterServiceVersions(csv.GetNamespace()).Delete(context.TODO(), csv.GetName(), *metav1.NewDeleteOptions(0))
1157+
return a.client.OperatorsV1alpha1().ClusterServiceVersions(csv.GetNamespace()).Delete(context.TODO(), csv.GetName(), metav1.DeleteOptions{})
11581158
}
11591159

11601160
// syncClusterServiceVersion is the method that gets called when we see a CSV event in the cluster
@@ -2105,7 +2105,7 @@ func (a *Operator) transitionCSVState(in v1alpha1.ClusterServiceVersion) (out *v
21052105
syncError = fmt.Errorf("marked as replacement, but no replacement CSV found in cluster")
21062106
}
21072107
case v1alpha1.CSVPhaseDeleting:
2108-
syncError = a.client.OperatorsV1alpha1().ClusterServiceVersions(out.GetNamespace()).Delete(context.TODO(), out.GetName(), *metav1.NewDeleteOptions(0))
2108+
syncError = a.client.OperatorsV1alpha1().ClusterServiceVersions(out.GetNamespace()).Delete(context.TODO(), out.GetName(), metav1.DeleteOptions{})
21092109
if syncError != nil {
21102110
logger.Debugf("unable to get delete csv marked for deletion: %s", syncError.Error())
21112111
}

0 commit comments

Comments
 (0)