Add helper func

Author: awgreene

crds/operators.coreos.com_olmconfigs.yaml

@@ -43,7 +43,6 @@ spec:
                     disableCopiedCSVs:
                       description: DisableCopiedCSVs is used to disable OLM's "Copied CSV" feature for operators installed at the cluster scope, where a cluster scoped operator is one that has been installed in an OperatorGroup that targets all namespaces. When reenabled, OLM will recreate the "Copied CSVs" for each cluster scoped operator.
                       type: boolean
-                      default: false
             status:
               description: OLMConfigStatus is the status for an OLMConfig resource.
               type: object

crds/zz_defs.go

@@ -0,0 +1,72 @@
+package v1
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func boolPointer(in bool) *bool {
+	return &in
+}
+
+func TestCopiedCSVsAreEnabled(t *testing.T) {
+	tests := []struct {
+		description string
+		olmConfig   *OLMConfig
+		expected    bool
+	}{
+		{
+			description: "NilConfig",
+			olmConfig:   nil,
+			expected:    false,
+		},
+		{
+			description: "MissingSpec",
+			olmConfig:   &OLMConfig{},
+			expected:    false,
+		},
+		{
+			description: "MissingFeatures",
+			olmConfig: &OLMConfig{
+				Spec: OLMConfigSpec{},
+			},
+			expected: false,
+		},
+		{
+			description: "MissingDisableCopiedCSVs",
+			olmConfig: &OLMConfig{
+				Spec: OLMConfigSpec{},
+			},
+			expected: false,
+		},
+		{
+			description: "CopiedCSVsDisabled",
+			olmConfig: &OLMConfig{
+				Spec: OLMConfigSpec{
+					Features: Features{
+						DisableCopiedCSVs: boolPointer(true),
+					},
+				},
+			},
+			expected: false,
+		},
+		{
+			description: "CopiedCSVsEnabled",
+			olmConfig: &OLMConfig{
+				Spec: OLMConfigSpec{
+					Features: Features{
+						DisableCopiedCSVs: boolPointer(false),
+					},
+				},
+			},
+			expected: true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.description, func(t *testing.T) {
+			require.EqualValues(t, tt.expected, tt.olmConfig.CopiedCSVsAreEnabled())
+		})
+	}
+}

pkg/operators/v1/olmconfig_test.go

@@ -11,15 +11,14 @@ type OLMConfigSpec struct {
 
 // Features contains the list of configurable OLM features.
 type Features struct {
-	// +kubebuilder:default=false
 
 	// DisableCopiedCSVs is used to disable OLM's "Copied CSV" feature
 	// for operators installed at the cluster scope, where a cluster
 	// scoped operator is one that has been installed in an
 	// OperatorGroup that targets all namespaces.
 	// When reenabled, OLM will recreate the "Copied CSVs" for each
 	// cluster scoped operator.
-	DisableCopiedCSVs bool `json:"disableCopiedCSVs,omitempty"`
+	DisableCopiedCSVs *bool `json:"disableCopiedCSVs,omitempty"`
 }
 
 // OLMConfigStatus is the status for an OLMConfig resource.
@@ -56,3 +55,16 @@ type OLMConfigList struct {
 func init() {
 	SchemeBuilder.Register(&OLMConfig{}, &OLMConfigList{})
 }
+
+func (config *OLMConfig) CopiedCSVsAreEnabled() bool {
+	if config == nil {
+		return true
+	}
+
+	disableCopiedCSVs := config.Spec.Features.DisableCopiedCSVs
+	if disableCopiedCSVs != nil {
+		return !*disableCopiedCSVs
+	}
+
+	return true
+}