Skip to content

Commit cb519f1

Browse files
committed
renaming and add yaml tags
Signed-off-by: Eric Stroczynski <[email protected]>
1 parent ed76771 commit cb519f1

File tree

2 files changed

+19
-19
lines changed

2 files changed

+19
-19
lines changed

pkg/constraints/constraint.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,22 +38,22 @@ type Constraint struct {
3838
// CompoundConstraint holds a list of potentially nested constraints
3939
// over which a boolean operation is applied.
4040
type CompoundConstraint struct {
41-
Constraints []Constraint `json:"constraints"`
41+
Constraints []Constraint `json:"constraints" yaml:"constraints"`
4242
}
4343

4444
// GVKConstraint defines a GVK constraint.
4545
type GVKConstraint struct {
46-
Group string `json:"group"`
47-
Kind string `json:"kind"`
48-
Version string `json:"version"`
46+
Group string `json:"group" yaml:"group"`
47+
Kind string `json:"kind" yaml:"kind"`
48+
Version string `json:"version" yaml:"version"`
4949
}
5050

5151
// PackageConstraint defines a package constraint.
5252
type PackageConstraint struct {
53-
// Name of the package.
54-
Name string `json:"name"`
53+
// PackageName is the name of the package.
54+
PackageName string `json:"packageName" yaml:"packageName"`
5555
// VersionRange required for the package.
56-
VersionRange string `json:"versionRange"`
56+
VersionRange string `json:"versionRange" yaml:"versionRange"`
5757
}
5858

5959
// maxConstraintSize defines the maximum raw size in bytes of an olm.constraint.

pkg/constraints/constraint_test.go

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ func TestParse(t *testing.T) {
3131
input: json.RawMessage(inputBasicPackage),
3232
expConstraint: Constraint{
3333
Message: "blah",
34-
Package: &PackageConstraint{Name: "foo", VersionRange: ">=1.0.0"},
34+
Package: &PackageConstraint{PackageName: "foo", VersionRange: ">=1.0.0"},
3535
},
3636
},
3737
{
@@ -43,7 +43,7 @@ func TestParse(t *testing.T) {
4343
Constraints: []Constraint{
4444
{
4545
Message: "blah blah",
46-
Package: &PackageConstraint{Name: "fuz", VersionRange: ">=1.0.0"},
46+
Package: &PackageConstraint{PackageName: "fuz", VersionRange: ">=1.0.0"},
4747
},
4848
},
4949
},
@@ -58,7 +58,7 @@ func TestParse(t *testing.T) {
5858
Constraints: []Constraint{
5959
{
6060
Message: "blah blah",
61-
Package: &PackageConstraint{Name: "fuz", VersionRange: ">=1.0.0"},
61+
Package: &PackageConstraint{PackageName: "fuz", VersionRange: ">=1.0.0"},
6262
},
6363
},
6464
},
@@ -73,7 +73,7 @@ func TestParse(t *testing.T) {
7373
Constraints: []Constraint{
7474
{
7575
Message: "blah blah",
76-
Package: &PackageConstraint{Name: "fuz", VersionRange: ">=1.0.0"},
76+
Package: &PackageConstraint{PackageName: "fuz", VersionRange: ">=1.0.0"},
7777
},
7878
},
7979
},
@@ -86,14 +86,14 @@ func TestParse(t *testing.T) {
8686
Message: "blah",
8787
All: &CompoundConstraint{
8888
Constraints: []Constraint{
89-
{Package: &PackageConstraint{Name: "fuz", VersionRange: ">=1.0.0"}},
89+
{Package: &PackageConstraint{PackageName: "fuz", VersionRange: ">=1.0.0"}},
9090
{GVK: &GVKConstraint{Group: "fals.example.com", Kind: "Fal", Version: "v1"}},
9191
{
9292
Message: "foo and buf must be stable versions",
9393
All: &CompoundConstraint{
9494
Constraints: []Constraint{
95-
{Package: &PackageConstraint{Name: "foo", VersionRange: ">=1.0.0"}},
96-
{Package: &PackageConstraint{Name: "buf", VersionRange: ">=1.0.0"}},
95+
{Package: &PackageConstraint{PackageName: "foo", VersionRange: ">=1.0.0"}},
96+
{Package: &PackageConstraint{PackageName: "buf", VersionRange: ">=1.0.0"}},
9797
{GVK: &GVKConstraint{Group: "foos.example.com", Kind: "Foo", Version: "v1"}},
9898
},
9999
},
@@ -164,7 +164,7 @@ const (
164164
inputBasicPackage = `{
165165
"message": "blah",
166166
"package": {
167-
"name": "foo",
167+
"packageName": "foo",
168168
"versionRange": ">=1.0.0"
169169
}
170170
}`
@@ -176,7 +176,7 @@ const (
176176
{
177177
"message": "blah blah",
178178
"package": {
179-
"name": "fuz",
179+
"packageName": "fuz",
180180
"versionRange": ">=1.0.0"
181181
}
182182
}
@@ -190,7 +190,7 @@ const (
190190
"constraints": [
191191
{
192192
"package": {
193-
"name": "fuz",
193+
"packageName": "fuz",
194194
"versionRange": ">=1.0.0"
195195
}
196196
},
@@ -207,13 +207,13 @@ const (
207207
"constraints": [
208208
{
209209
"package": {
210-
"name": "foo",
210+
"packageName": "foo",
211211
"versionRange": ">=1.0.0"
212212
}
213213
},
214214
{
215215
"package": {
216-
"name": "buf",
216+
"packageName": "buf",
217217
"versionRange": ">=1.0.0"
218218
}
219219
},

0 commit comments

Comments
 (0)