Add format to verify target #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the verify target to include the format target as a prerequisite. This commit also includes changes introduced after running the format target.
awgreene
force-pushed
the
add-format-to-verify-target
branch
from
aa1d0d3 to
6e7efb9
Compare
timflannagan
reviewed
Dec 6, 2021
| @@ -1,6 +1,6 @@ | |||
| // Code generated by go-bindata. (@generated) DO NOT EDIT. | |||
|
|
|||
| //Package crds generated by go-bindata.// sources: | |||
There was a problem hiding this comment.
Do we want to be formatting generated files? Can we adjust the fmt target to filter out certain files/directories/etc.?
There was a problem hiding this comment.
IMO if the generator isn't formatting Go files it has a bug, so I'm fine with formatting everything (with the exception of vendor dirs).
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the verify target to include the
format target as a prerequisite. This commit also
includes changes introduced after running the format
target.