This repository was archived by the owner on Sep 21, 2020. It is now read-only.
Added custom resource definition instructions #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
Hi @jroper. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-ok-to-test
jroper
force-pushed
the
add-custom-resource-instructions
branch
from
23c23af to
819b169
Compare
openshift-ci-robot
added
size/M
|
Updated to reflect feedback in #29 (comment). |
hasbro17
approved these changes
Nov 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29.
Adds the missing instructions for adding an API definition for custom resources.
Note, I have no idea what I'm doing, I'm just trying to follow the getting started guide myself to learn about operators, and worked out that this step appears to be missing. If anything here is wrong, it will likely be far more expedient for someone who actually knows what they are doing to fix it.