This repository was archived by the owner on Jan 25, 2019. It is now read-only.
helm-app-operator: transitioning to use controller-runtime #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasbro17
reviewed
Oct 10, 2018
| func NewInstallerFromEnv(storageBackend *storage.Storage, tillerKubeClient *kube.Client) (schema.GroupVersionKind, Installer, error) { | ||
| apiVersion := os.Getenv(APIVersionEnvVar) | ||
| kind := os.Getenv(KindEnvVar) | ||
| chartDir := os.Getenv(HelmChartEnvVar) |
There was a problem hiding this comment.
I know the changes form this PR are temporary, but these envs could be unset.
Not sure what happens in that case with an nil valued gvk.
There was a problem hiding this comment.
Good catch. The controller eventually panicked trying to add the watches, which I think was the behavior before as well. Updated with some validation.
|
Change the build step to cmd/manager/main.go |
This was referenced Oct 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controller-runtimeAPIs (e.g. config, manager, controller, reconciler, etc.)cmd/helm-app-operator/main.gotocmd/manager/main.gopkg/stub/handler.gotopkg/helm/controller/reconcile.gopkg/helm/client.goto usemanager.Managerv1alpha1.StatusForand added passing test.