Skip to content

switch to golangci config; simplify Makefile #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
linters:
disable-all: true
enable:
- nakedret
- interfacer
- varcheck
- deadcode
- structcheck
- misspell
- maligned
- ineffassign
- goconst
- goimports
- errcheck
- unparam
- golint
- staticcheck
- gosimple
- unused
- govet
- typecheck

run:
deadline: 5m
20 changes: 1 addition & 19 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,25 +9,7 @@ build: $(SOURCES) ## Build Test
go build -i -ldflags="-s -w" ./...

lint: golangci-lint ## Run golint
@golangci-lint run --disable-all \
--deadline 5m \
--enable=nakedret \
--enable=interfacer \
--enable=varcheck \
--enable=deadcode \
--enable=structcheck \
--enable=misspell \
--enable=maligned \
--enable=ineffassign \
--enable=goconst \
--enable=goimports \
--enable=errcheck \
--enable=dupl \
--enable=unparam \
--enable=golint \
--enable=staticcheck \
--enable=unused \
--enable=gosimple \
@$(GOLANGCI_LINT) run

fmt: ## Run go fmt
@gofmt -d $(SOURCES)
Expand Down