Fix a flaky CRD test.

In this test, a Subscription's channel is updated, then the same
Subscription is immediately fetched. If this fetch happens before the
Subscription's InstallPlanRef is updated, then subsequent assertions
are made against the wrong InstallPlan.

Author: benluddy

test/e2e/crd_e2e_test.go

@@ -307,8 +307,12 @@ var _ = Describe("CRD Versions", func() {
 		_, err = crc.OperatorsV1alpha1().Subscriptions(testNamespace).Update(context.TODO(), sub, metav1.UpdateOptions{})
 		Expect(err).ToNot(HaveOccurred(), "could not update subscription")
 
+		subscriptionAtLatestWithDifferentInstallPlan := func(v *operatorsv1alpha1.Subscription) bool {
+			return subscriptionStateAtLatestChecker(v) && v.Status.InstallPlanRef != nil && v.Status.InstallPlanRef.Name != fetchedInstallPlan.Name
+		}
+
 		// fetch new subscription
-		s, err := fetchSubscription(crc, testNamespace, subscriptionName, subscriptionStateAtLatestChecker)
+		s, err := fetchSubscription(crc, testNamespace, subscriptionName, subscriptionAtLatestWithDifferentInstallPlan)
 		Expect(err).ToNot(HaveOccurred())
 		Expect(s).ToNot(BeNil())
 		Expect(s.Status.InstallPlanRef).ToNot(Equal(nil))