fix(e2e): Remove the PreExistingCRDOwnerIsReplaced e2e test case (#2388)

The PreExistingCRDOwnerIsReplaced test case is no longer applicable
as the ownership replacement check has been removed from olm. This
test was introduced when olm only allowed one single ownership of
CRD.

Signed-off-by: Vu Dinh <[email protected]>

Author: dinhxuanvu

test/e2e/installplan_e2e_test.go

@@ -901,140 +901,6 @@ var _ = Describe("Install Plan", func() {
 			// Should have removed every matching step
 			require.Equal(GinkgoT(), 0, len(expectedSteps), "Actual resource steps do not match expected")
 		})
-		It("PreExistingCRDOwnerIsReplaced", func() {
-
-			mainPackageName := genName("nginx-")
-			dependentPackageName := genName("nginx-dep-")
-
-			mainPackageStable := fmt.Sprintf("%s-stable", mainPackageName)
-			mainPackageBeta := fmt.Sprintf("%s-beta", mainPackageName)
-			dependentPackageStable := fmt.Sprintf("%s-stable", dependentPackageName)
-
-			stableChannel := "stable"
-			betaChannel := "beta"
-
-			// Create manifests
-			mainManifests := []registry.PackageManifest{
-				{
-					PackageName: mainPackageName,
-					Channels: []registry.PackageChannel{
-						{Name: stableChannel, CurrentCSVName: mainPackageStable},
-						{Name: betaChannel, CurrentCSVName: mainPackageBeta},
-					},
-					DefaultChannelName: stableChannel,
-				},
-				{
-					PackageName: dependentPackageName,
-					Channels: []registry.PackageChannel{
-						{Name: stableChannel, CurrentCSVName: dependentPackageStable},
-					},
-					DefaultChannelName: stableChannel,
-				},
-			}
-
-			// Create new CRDs
-			mainCRD := newCRD(genName("ins-"))
-			dependentCRD := newCRD(genName("ins-"))
-
-			// Create new CSVs
-			mainStableCSV := newCSV(mainPackageStable, testNamespace, "", semver.MustParse("0.1.0"), []apiextensions.CustomResourceDefinition{mainCRD}, []apiextensions.CustomResourceDefinition{dependentCRD}, nil)
-			mainBetaCSV := newCSV(mainPackageBeta, testNamespace, mainPackageStable, semver.MustParse("0.2.0"), []apiextensions.CustomResourceDefinition{mainCRD}, []apiextensions.CustomResourceDefinition{dependentCRD}, nil)
-			dependentStableCSV := newCSV(dependentPackageStable, testNamespace, "", semver.MustParse("0.1.0"), []apiextensions.CustomResourceDefinition{dependentCRD}, nil, nil)
-
-			c := newKubeClient()
-			crc := newCRClient()
-			defer func() {
-				require.NoError(GinkgoT(), crc.OperatorsV1alpha1().Subscriptions(testNamespace).DeleteCollection(context.TODO(), metav1.DeleteOptions{}, metav1.ListOptions{}))
-			}()
-
-			// Create the catalog source
-			mainCatalogSourceName := genName("mock-ocs-main-" + strings.ToLower(CurrentGinkgoTestDescription().TestText) + "-")
-			_, cleanupCatalogSource := createInternalCatalogSource(c, crc, mainCatalogSourceName, testNamespace, mainManifests, []apiextensions.CustomResourceDefinition{dependentCRD, mainCRD}, []operatorsv1alpha1.ClusterServiceVersion{dependentStableCSV, mainStableCSV, mainBetaCSV})
-			defer cleanupCatalogSource()
-
-			// Attempt to get the catalog source before creating install plan(s)
-			_, err := fetchCatalogSourceOnStatus(crc, mainCatalogSourceName, testNamespace, catalogSourceRegistryPodSynced)
-			require.NoError(GinkgoT(), err)
-
-			subscriptionName := genName("sub-nginx-")
-			subscriptionCleanup := createSubscriptionForCatalog(crc, testNamespace, subscriptionName, mainCatalogSourceName, mainPackageName, stableChannel, "", operatorsv1alpha1.ApprovalAutomatic)
-			defer subscriptionCleanup()
-
-			subscription, err := fetchSubscription(crc, testNamespace, subscriptionName, subscriptionHasInstallPlanChecker)
-			require.NoError(GinkgoT(), err)
-			require.NotNil(GinkgoT(), subscription)
-
-			installPlanName := subscription.Status.InstallPlanRef.Name
-
-			// Wait for InstallPlan to be status: Complete or failed before checking resource presence
-			completeOrFailedFunc := buildInstallPlanPhaseCheckFunc(operatorsv1alpha1.InstallPlanPhaseComplete, operatorsv1alpha1.InstallPlanPhaseFailed)
-			fetchedInstallPlan, err := fetchInstallPlan(GinkgoT(), crc, installPlanName, completeOrFailedFunc)
-			require.NoError(GinkgoT(), err)
-			GinkgoT().Logf("Install plan %s fetched with status %s", fetchedInstallPlan.GetName(), fetchedInstallPlan.Status.Phase)
-			require.Equal(GinkgoT(), operatorsv1alpha1.InstallPlanPhaseComplete, fetchedInstallPlan.Status.Phase)
-
-			// Ensure that the desired resources have been created
-			expectedSteps := map[registry.ResourceKey]struct{}{
-				{Name: mainCRD.Name, Kind: "CustomResourceDefinition"}:                                                                                      {},
-				{Name: dependentCRD.Name, Kind: "CustomResourceDefinition"}:                                                                                 {},
-				{Name: dependentPackageStable, Kind: operatorsv1alpha1.ClusterServiceVersionKind}:                                                           {},
-				{Name: mainPackageStable, Kind: operatorsv1alpha1.ClusterServiceVersionKind}:                                                                {},
-				{Name: strings.Join([]string{dependentPackageStable, mainCatalogSourceName, testNamespace}, "-"), Kind: operatorsv1alpha1.SubscriptionKind}: {},
-			}
-
-			require.Equal(GinkgoT(), len(expectedSteps), len(fetchedInstallPlan.Status.Plan), "number of expected steps does not match installed")
-
-			for _, step := range fetchedInstallPlan.Status.Plan {
-				key := registry.ResourceKey{
-					Name: step.Resource.Name,
-					Kind: step.Resource.Kind,
-				}
-				_, ok := expectedSteps[key]
-				require.True(GinkgoT(), ok, "couldn't find %v in expected steps: %#v", key, expectedSteps)
-
-				// Remove the entry from the expected steps set (to ensure no duplicates in resolved plan)
-				delete(expectedSteps, key)
-			}
-
-			// Should have removed every matching step
-			require.Equal(GinkgoT(), 0, len(expectedSteps), "Actual resource steps do not match expected")
-
-			// Update the subscription resource to point to the beta CSV
-			err = crc.OperatorsV1alpha1().Subscriptions(testNamespace).DeleteCollection(context.TODO(), *metav1.NewDeleteOptions(0), metav1.ListOptions{})
-			require.NoError(GinkgoT(), err)
-
-			// Delete orphaned csv
-			require.NoError(GinkgoT(), crc.OperatorsV1alpha1().ClusterServiceVersions(testNamespace).Delete(context.TODO(), mainStableCSV.GetName(), metav1.DeleteOptions{}))
-
-			// existing cleanup should remove this
-			createSubscriptionForCatalog(crc, testNamespace, subscriptionName, mainCatalogSourceName, mainPackageName, betaChannel, "", operatorsv1alpha1.ApprovalAutomatic)
-
-			subscription, err = fetchSubscription(crc, testNamespace, subscriptionName, subscriptionHasInstallPlanChecker)
-			require.NoError(GinkgoT(), err)
-			require.NotNil(GinkgoT(), subscription)
-
-			installPlanName = subscription.Status.InstallPlanRef.Name
-
-			// Wait for InstallPlan to be status: Complete or Failed before checking resource presence
-			fetchedInstallPlan, err = fetchInstallPlan(GinkgoT(), crc, installPlanName, buildInstallPlanPhaseCheckFunc(operatorsv1alpha1.InstallPlanPhaseComplete, operatorsv1alpha1.InstallPlanPhaseFailed))
-			require.NoError(GinkgoT(), err)
-			GinkgoT().Logf("Install plan %s fetched with status %s", fetchedInstallPlan.GetName(), fetchedInstallPlan.Status.Phase)
-
-			require.Equal(GinkgoT(), operatorsv1alpha1.InstallPlanPhaseComplete, fetchedInstallPlan.Status.Phase)
-
-			// Fetch installplan again to check for unnecessary control loops
-			fetchedInstallPlan, err = fetchInstallPlan(GinkgoT(), crc, fetchedInstallPlan.GetName(), func(fip *operatorsv1alpha1.InstallPlan) bool {
-				compareResources(GinkgoT(), fetchedInstallPlan, fip)
-				return true
-			})
-			require.NoError(GinkgoT(), err)
-
-			// Ensure correct in-cluster resource(s)
-			fetchedCSV, err := fetchCSV(crc, mainBetaCSV.GetName(), testNamespace, csvSucceededChecker)
-			require.NoError(GinkgoT(), err)
-			GinkgoT().Logf("All expected resources resolved %s", fetchedCSV.Status.Phase)
-		})
-
 	})
 
 	Describe("with CRD schema change", func() {