Skip to content

Commit 28904dd

Browse files
committed
fix disable copied csv e2e test failure
Signed-off-by: akihikokuroda <[email protected]>
1 parent b3cded1 commit 28904dd

File tree

1 file changed

+67
-18
lines changed

1 file changed

+67
-18
lines changed

test/e2e/csv_e2e_test.go

Lines changed: 67 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4204,29 +4204,78 @@ var _ = Describe("Disabling copied CSVs", func() {
42044204
},
42054205
},
42064206
}
4207+
BeforeEach(func() {
4208+
Eventually(func() error {
42074209

4208-
When("an operator is installed in AllNamespace mode", func() {
4209-
BeforeEach(func() {
4210-
Eventually(func() error {
4211-
if err := ctx.Ctx().Client().Create(context.TODO(), ns); err != nil && !k8serrors.IsAlreadyExists(err) {
4212-
ctx.Ctx().Logf("Unable to create ns: %v", err)
4213-
return err
4214-
}
4210+
ns = &corev1.Namespace{
4211+
ObjectMeta: metav1.ObjectMeta{
4212+
Name: genName("csv-toggle-test-"),
4213+
},
4214+
}
42154215

4216-
if err := ctx.Ctx().Client().Create(context.TODO(), &operatorGroup); err != nil && !k8serrors.IsAlreadyExists(err) {
4217-
ctx.Ctx().Logf("Unable to create og: %v", err)
4218-
return err
4219-
}
4216+
operatorGroup = operatorsv1.OperatorGroup{
4217+
ObjectMeta: metav1.ObjectMeta{
4218+
Name: genName("csv-toggle-test-"),
4219+
Namespace: ns.GetName(),
4220+
},
4221+
}
42204222

4221-
if err := ctx.Ctx().Client().Create(context.TODO(), &csv); err != nil && !k8serrors.IsAlreadyExists(err) {
4222-
ctx.Ctx().Logf("Unable to create csv: %v", err)
4223-
return err
4224-
}
4223+
csv = operatorsv1alpha1.ClusterServiceVersion{
4224+
ObjectMeta: metav1.ObjectMeta{
4225+
Name: genName("csv-toggle-test-"),
4226+
Namespace: ns.GetName(),
4227+
},
4228+
Spec: operatorsv1alpha1.ClusterServiceVersionSpec{
4229+
InstallStrategy: newNginxInstallStrategy(genName("csv-toggle-test-"), nil, nil),
4230+
InstallModes: []operatorsv1alpha1.InstallMode{
4231+
{
4232+
Type: operatorsv1alpha1.InstallModeTypeAllNamespaces,
4233+
Supported: true,
4234+
},
4235+
},
4236+
},
4237+
}
42254238

4226-
return nil
4227-
}).Should(Succeed())
4228-
})
4239+
if err := ctx.Ctx().Client().Create(context.TODO(), ns); err != nil && !k8serrors.IsAlreadyExists(err) {
4240+
ctx.Ctx().Logf("Unable to create ns: %v", err)
4241+
return err
4242+
}
4243+
if err := ctx.Ctx().Client().Create(context.TODO(), &operatorGroup); err != nil && !k8serrors.IsAlreadyExists(err) {
4244+
ctx.Ctx().Logf("Unable to create og: %v", err)
4245+
return err
4246+
}
42294247

4248+
if err := ctx.Ctx().Client().Create(context.TODO(), &csv); err != nil && !k8serrors.IsAlreadyExists(err) {
4249+
ctx.Ctx().Logf("Unable to create csv: %v", err)
4250+
return err
4251+
}
4252+
4253+
return nil
4254+
}).Should(Succeed())
4255+
4256+
})
4257+
AfterEach(func() {
4258+
Eventually(func() error {
4259+
err := ctx.Ctx().Client().Delete(context.TODO(), &csv)
4260+
if err != nil {
4261+
return err
4262+
}
4263+
4264+
err = ctx.Ctx().Client().Delete(context.TODO(), &operatorGroup)
4265+
if err != nil {
4266+
return err
4267+
}
4268+
4269+
err = ctx.Ctx().Client().Delete(context.TODO(), ns)
4270+
if err != nil {
4271+
return err
4272+
}
4273+
4274+
return nil
4275+
}).Should(Succeed())
4276+
})
4277+
4278+
When("an operator is installed in AllNamespace mode", func() {
42304279
It("should have Copied CSVs in all other namespaces", func() {
42314280
Eventually(func() error {
42324281
requirement, err := k8slabels.NewRequirement(operatorsv1alpha1.CopiedLabelKey, selection.Equals, []string{csv.GetNamespace()})

0 commit comments

Comments
 (0)