Skip to content

Commit 33b957d

Browse files
committed
(fix)registry: fix configmap registry server liveness probe timeouts
Failing readiness/liveness probe fires prometheus alerts for CatalogSources backed by configmap registry servers. In #1378, the readiness probe initial delay and timeout were bumped to account for node resource constraints during pod startup. This PR bumps the liveness probe delay and timeout values too, to account for scenarios where node resources continue to be overloaded causing the liveness probe to fail temporarily. Signed-off-by: Anik Bhattacharjee <[email protected]>
1 parent e5309b6 commit 33b957d

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

pkg/controller/registry/reconciler/configmap.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ func (s *configMapCatalogSourceDecorator) Service() *v1.Service {
101101
}
102102

103103
func (s *configMapCatalogSourceDecorator) Pod(image string) *v1.Pod {
104-
pod := Pod(s.CatalogSource, "configmap-registry-server", image, "", s.Labels(), s.Annotations(), 5, 2)
104+
pod := Pod(s.CatalogSource, "configmap-registry-server", image, "", s.Labels(), s.Annotations(), 5, 5)
105105
pod.Spec.ServiceAccountName = s.GetName() + ConfigMapServerPostfix
106106
pod.Spec.Containers[0].Command = []string{"configmap-server", "-c", s.Spec.ConfigMap, "-n", s.GetNamespace()}
107107
ownerutil.AddOwner(pod, s.CatalogSource, false, false)

pkg/controller/registry/reconciler/reconciler.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ func Pod(source *v1alpha1.CatalogSource, name string, image string, saName strin
139139
},
140140
},
141141
InitialDelaySeconds: livenessDelay,
142+
TimeoutSeconds: 5,
142143
},
143144
Resources: v1.ResourceRequirements{
144145
Requests: v1.ResourceList{

0 commit comments

Comments
 (0)