Skip to content

Commit 48a7503

Browse files
committed
fix: remove extra type inference
1 parent 74da4a8 commit 48a7503

File tree

2 files changed

+14
-29
lines changed

2 files changed

+14
-29
lines changed

pkg/lib/operatorlister/lister.go

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -190,13 +190,13 @@ func newOperatorsV1Lister() *operatorsV1Lister {
190190
var _ OperatorLister = &lister{}
191191

192192
type lister struct {
193-
appsV1Lister *appsV1Lister
194-
coreV1Lister *coreV1Lister
195-
rbacV1Lister *rbacV1Lister
196-
apiRegistrationV1Lister *apiRegistrationV1Lister
197-
apiExtensionsV1Lister *apiExtensionsV1Lister
198-
operatorsV1alpha1Lister *operatorsV1alpha1Lister
199-
operatorsV1Lister *operatorsV1Lister
193+
appsV1Lister *appsV1Lister
194+
coreV1Lister *coreV1Lister
195+
rbacV1Lister *rbacV1Lister
196+
apiRegistrationV1Lister *apiRegistrationV1Lister
197+
apiExtensionsV1Lister *apiExtensionsV1Lister
198+
operatorsV1alpha1Lister *operatorsV1alpha1Lister
199+
operatorsV1Lister *operatorsV1Lister
200200
}
201201

202202
func (l *lister) AppsV1() AppsV1Lister {
@@ -230,12 +230,12 @@ func (l *lister) OperatorsV1() OperatorsV1Lister {
230230
func NewLister() OperatorLister {
231231
// TODO: better initialization
232232
return &lister{
233-
appsV1Lister: newAppsV1Lister(),
234-
coreV1Lister: newCoreV1Lister(),
235-
rbacV1Lister: newRbacV1Lister(),
236-
apiRegistrationV1Lister: newAPIRegistrationV1Lister(),
237-
apiExtensionsV1Lister: newAPIExtensionsV1Lister(),
238-
operatorsV1alpha1Lister: newOperatorsV1alpha1Lister(),
239-
operatorsV1Lister: newOperatorsV1Lister(),
233+
appsV1Lister: newAppsV1Lister(),
234+
coreV1Lister: newCoreV1Lister(),
235+
rbacV1Lister: newRbacV1Lister(),
236+
apiRegistrationV1Lister: newAPIRegistrationV1Lister(),
237+
apiExtensionsV1Lister: newAPIExtensionsV1Lister(),
238+
operatorsV1alpha1Lister: newOperatorsV1alpha1Lister(),
239+
operatorsV1Lister: newOperatorsV1Lister(),
240240
}
241241
}

pkg/lib/ownerutil/util.go

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@ import (
88

99
log "github.com/sirupsen/logrus"
1010
corev1 "k8s.io/api/core/v1"
11-
policyv1beta1 "k8s.io/api/policy/v1beta1"
1211
rbac "k8s.io/api/rbac/v1"
13-
schedulingv1 "k8s.io/api/scheduling/v1"
1412
apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
1513
apiextensionsv1beta1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1"
1614
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -400,19 +398,6 @@ func InferGroupVersionKind(obj runtime.Object) error {
400398
Version: apiextensionsv1.SchemeGroupVersion.Version,
401399
Kind: "CustomResourceDefinition",
402400
})
403-
case *policyv1beta1.PodDisruptionBudget:
404-
objectKind.SetGroupVersionKind(schema.GroupVersionKind{
405-
Group: policyv1beta1.GroupName,
406-
Version: policyv1beta1.SchemeGroupVersion.Version,
407-
Kind: "PodDisruptionBudget",
408-
})
409-
case *schedulingv1.PriorityClass:
410-
objectKind.SetGroupVersionKind(schema.GroupVersionKind{
411-
Group: schedulingv1.GroupName,
412-
Version: schedulingv1.SchemeGroupVersion.Version,
413-
Kind: "PriorityClass",
414-
})
415-
// TODO add GVK for VPA objects
416401
default:
417402
return fmt.Errorf("could not infer GVK for object: %#v, %#v", obj, objectKind)
418403
}

0 commit comments

Comments
 (0)