Skip to content

Commit 5662bc2

Browse files
committed
Add unit test to verify non-empty selector from CSVOwnerSelector
The CSVOwnerSelector should never return an empty selector (which is equavalent of Everything()). Signed-off-by: Vu Dinh <[email protected]>
1 parent ad5171a commit 5662bc2

File tree

1 file changed

+60
-1
lines changed

1 file changed

+60
-1
lines changed

pkg/lib/ownerutil/util_test.go

Lines changed: 60 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,66 @@
11
package ownerutil
22

3-
import "testing"
3+
import (
4+
"testing"
5+
6+
"github.com/stretchr/testify/assert"
7+
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
8+
9+
operatorsv1alpha1 "github.com/operator-framework/api/pkg/operators/v1alpha1"
10+
)
411

512
func TestIsOwnedBy(t *testing.T) {
613
return
714
}
15+
16+
func TestCSVOwnerSelector(t *testing.T) {
17+
csvType := metav1.TypeMeta{
18+
Kind: operatorsv1alpha1.ClusterServiceVersionKind,
19+
APIVersion: operatorsv1alpha1.GroupVersion,
20+
}
21+
22+
tests := []struct {
23+
name string
24+
csv *operatorsv1alpha1.ClusterServiceVersion
25+
}{
26+
{
27+
name: "CSV with name longer than 63 characters",
28+
csv: &operatorsv1alpha1.ClusterServiceVersion{
29+
TypeMeta: csvType,
30+
ObjectMeta: metav1.ObjectMeta{
31+
Name: "clusterkubedescheduleroperator.4.6.0-202106010807.p0.git.5db84c5",
32+
Namespace: "test-namespace",
33+
},
34+
},
35+
},
36+
{
37+
name: "CSV with invalid name",
38+
csv: &operatorsv1alpha1.ClusterServiceVersion{
39+
TypeMeta: csvType,
40+
ObjectMeta: metav1.ObjectMeta{
41+
Name: "something@somewhere",
42+
Namespace: "test-namespace",
43+
},
44+
},
45+
},
46+
{
47+
name: "CSV with empty string name",
48+
csv: &operatorsv1alpha1.ClusterServiceVersion{
49+
TypeMeta: csvType,
50+
ObjectMeta: metav1.ObjectMeta{
51+
Name: "",
52+
Namespace: "test-namespace",
53+
},
54+
},
55+
},
56+
}
57+
58+
for _, tt := range tests {
59+
t.Run(tt.name, func(t *testing.T) {
60+
selector := CSVOwnerSelector(tt.csv)
61+
62+
assert.NotNil(t, selector)
63+
assert.False(t, selector.Empty())
64+
})
65+
}
66+
}

0 commit comments

Comments
 (0)