Avoid modifying object retrieved from lister

awgreene · awgreene · commit 64cd2ccd6386 · 2022-01-10T15:42:55.000-08:00
Problem: Objects retrieved from the lister should
not be modified.

Solution: Return a DeepCopy of the object retrieved
from the lister which can then be manipulated as
needed.

Signed-off-by: Alexander Greene &lt;greene.al1991@gmail.com&gt;
diff --git a/pkg/controller/operators/olm/operator.go b/pkg/controller/operators/olm/operator.go
@@ -1627,7 +1627,7 @@ func (a *Operator) operatorGroupForCSV(csv *v1alpha1.ClusterServiceVersion, logg
 			return nil, nil
 		}
 		logger.Debug("csv in operatorgroup")
-		return operatorGroup, nil
+		return operatorGroup.DeepCopy(), nil
 	default:
 		err = fmt.Errorf("csv created in namespace with multiple operatorgroups, can't pick one automatically")
 		logger.WithError(err).Warn("csv failed to become an operatorgroup member")

Original file line number	Diff line number	Diff line change
`@@ -1627,7 +1627,7 @@ func (a Operator) operatorGroupForCSV(csv v1alpha1.ClusterServiceVersion, logg`
`1627`	`1627`	`return nil, nil`
`1628`	`1628`	`}`
`1629`	`1629`	`logger.Debug("csv in operatorgroup")`
`1630`		`- return operatorGroup, nil`
	`1630`	`+ return operatorGroup.DeepCopy(), nil`
`1631`	`1631`	`default:`
`1632`	`1632`	`err = fmt.Errorf("csv created in namespace with multiple operatorgroups, can't pick one automatically")`
`1633`	`1633`	`logger.WithError(err).Warn("csv failed to become an operatorgroup member")`