Add unit test for generic constraint

Signed-off-by: Vu Dinh <[email protected]>

Author: dinhxuanvu

pkg/controller/registry/resolver/resolver_test.go

@@ -2066,3 +2066,121 @@ func TestNewOperatorFromCSV(t *testing.T) {
 		})
 	}
 }
+
+func TestSolveOperators_GenericConstraint(t *testing.T) {
+	Provides1 := cache.APISet{opregistry.APIKey{"g", "v", "k", "ks"}: struct{}{}}
+	Provides2 := cache.APISet{opregistry.APIKey{"g2", "v", "k", "ks"}: struct{}{}}
+
+	namespace := "olm"
+	catalog := cache.SourceKey{Name: "community", Namespace: namespace}
+
+	phases := []struct {
+		isErr    bool
+		subs     []*v1alpha1.Subscription
+		deps     []*api.Dependency
+		catalog  cache.Source
+		expected cache.OperatorSet
+	}{
+		{
+			// generic constraint for satisfiable gvk dependency
+			isErr: false,
+			subs:  []*v1alpha1.Subscription{newSub(namespace, "packageA", "stable", catalog)},
+			deps: []*api.Dependency{
+				{
+					Type: "olm.constraint",
+					Value: `{"message":"gvk-constraint",
+						"cel":{"rule":"properties.exists(p, p.type == "olm.gvk" && p.value == {"group": "g", 'version': "v", 'kind': "k"})"}}`,
+				},
+			},
+			catalog: &cache.Snapshot{
+				Entries: []*cache.Entry{
+					genOperator("opA.v1.0.0", "1.0.0", "", "packageA", "stable", catalog.Name, catalog.Namespace, nil, nil, deps, "", false),
+					genOperator("opB.v1.0.0", "1.0.0", "", "packageB", "stable", catalog.Name, catalog.Namespace, nil, Provides1, nil, "stable", false),
+				},
+			},
+			expected: cache.OperatorSet{
+				"opA.v1.0.0": genOperator("opA.v1.0.0", "1.0.0", "", "packageA", "stable", catalog.Name, catalog.Namespace, nil, nil, deps, "", false),
+				"opB.v1.0.0": genOperator("opB.v1.0.0", "1.0.0", "", "packageB", "stable", catalog.Name, catalog.Namespace, nil, Provides1, nil, "stable", false),
+			},
+		},
+		{
+			// generic constraint for NotSatisfiable gvk dependency
+			isErr: true,
+			subs: []*v1alpha1.Subscription{
+				subs(namespace, "opA.v1.0.0", "packageA", "stable", catalog),
+			},
+			deps: []*api.Dependency{
+				{
+					Type: "olm.constraint",
+					Value: `{"message":"gvk2-constraint",
+						"cel":{"rule":"properties.exists(p, p.type == "olm.gvk" && p.value == {"group": "g2", 'version': "v", 'kind': "k"})"}}`,
+				},
+			},
+			catalog: &cache.Snapshot{
+				Entries: []*cache.Entry{
+					genOperator("opA.v1.0.0", "1.0.0", "", "packageA", "stable", catalog.Name, catalog.Namespace, nil, nil, nil, "", false),
+					genOperator("opB.v1.0.0", "1.0.0", "", "packageB", "stable", catalog.Name, catalog.Namespace, nil, Provides2, nil, "", false),
+				},
+			},
+			// unable to find satisfiable gvk dependency
+			// resolve into nothing
+			expected: cache.OperatorSet{},
+		},
+		{
+			// generic constraint for package constraint
+			isErr: false,
+			subs: []*v1alpha1.Subscription{
+				subs(namespace, "opA.v1.0.0", "packageA", "stable", catalog),
+			},
+			deps: []*api.Dependency{
+				{
+					Type: "olm.constraint",
+					Value: `{"message":"compound-constraint",
+						"cel":{"rule":"properties.exists(p, p.type == "olm.package" && (semver_compare(p.value, 1.0.1) == 0))"}}`,
+				},
+			},
+			catalog: &cache.Snapshot{
+				Entries: []*cache.Entry{
+					genOperator("opA.v1.0.0", "1.0.0", "", "packageA", "stable", catalog.Name, catalog.Namespace, nil, nil, deps, "", false),
+					genOperator("opB.v1.0.0", "1.0.0", "", "packageB", "stable", catalog.Name, catalog.Namespace, nil, nil, nil, "", false),
+					genOperator("opB.v1.0.1", "1.0.1", "opB.v1.0.0", "packageB", "stable", catalog.Name, catalog.Namespace, nil, nil, nil, "stable", false),
+					genOperator("opB.v1.0.2", "1.0.2", "opB.v1.0.1", "packageB", "stable", catalog.Name, catalog.Namespace, nil, nil, nil, "stable", false),
+				},
+			},
+			expected: cache.OperatorSet{
+				"opA.v1.0.0": genOperator("opA.v1.0.1", "1.0.1", "", "packageA", "stable", catalog.Name, catalog.Namespace, nil, nil, deps, "", false),
+				"opB.v1.0.1": genOperator("opB.v1.0.1", "1.0.1", "opB.v1.0.0", "packageB", "stable", catalog.Name, catalog.Namespace, nil, nil, nil, "stable", false),
+			},
+		},
+	}
+
+	var operators cache.OperatorSet
+	for i, p := range phases {
+		t.Run(fmt.Sprintf("phase %d", i+1), func(t *testing.T) {
+			satResolver := SatResolver{
+				cache: cache.New(cache.StaticSourceProvider{
+					catalog: p.catalog,
+				}),
+				log: logrus.New(),
+			}
+			csvs := make([]*v1alpha1.ClusterServiceVersion, 0)
+			for _, o := range operators {
+				var pkg, channel string
+				if si := o.SourceInfo; si != nil {
+					pkg = si.Package
+					channel = si.Channel
+				}
+				csvs = append(csvs, existingOperator(namespace, o.Name, pkg, channel, o.Replaces, o.ProvidedAPIs, o.RequiredAPIs, nil, nil))
+			}
+
+			var err error
+			operators, err = satResolver.SolveOperators([]string{"olm"}, csvs, p.subs)
+			assert.NoError(t, err)
+			for k := range p.expected {
+				require.NotNil(t, operators[k])
+				assert.EqualValues(t, k, operators[k].Name)
+			}
+			assert.Equal(t, len(p.expected), len(operators))
+		})
+	}
+}

pkg/controller/registry/resolver/source_registry.go

@@ -233,6 +233,11 @@ func legacyDependenciesToProperties(dependencies []*api.Dependency) ([]*api.Prop
 				Type:  "olm.label.required",
 				Value: dependency.Value,
 			})
+		case "olm.constraint":
+			result = append(result, &api.Property{
+				Type:  "olm.constraint",
+				Value: dependency.Value,
+			})
 		}
 	}
 	return result, nil