Skip to content

Commit 9cdc17c

Browse files
author
bowenislandsong
committed
fix: Use PR head commit in artifact naming instead of merge commit
The env var GITHUB_SHA shows merge commit and is not related to worflow trigger unlike the discription on GITHUB. This fix changes the variable to look at the head commit aka. the commit that actually triggers the workflow.
1 parent cf8d964 commit 9cdc17c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/e2e-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@ jobs:
1414
if: ${{ failure() }}
1515
uses: actions/upload-artifact@v2
1616
with:
17-
name: e2e-test-output-${{ github.sha }}-${{ github.run_id }}
17+
name: e2e-test-output-${{(github.event.pull_request.head.sha||github.sha)}}-${{ github.run_id }}
1818
path: ${{ github.workspace }}/bin/artifacts/*

0 commit comments

Comments
 (0)