Draft: Deprecated inner channel entries cause resolution error.

Signed-off-by: Ben Luddy <[email protected]>

Author: benluddy

pkg/controller/registry/resolver/resolver_test.go

@@ -1362,6 +1362,62 @@ func TestSolveOperators_WithoutDeprecated(t *testing.T) {
 	assert.IsType(t, solver.NotSatisfiable{}, err)
 }
 
+func TestSolveOperatorsWithDeprecatedInnerChannelEntry(t *testing.T) {
+	catalog := registry.CatalogKey{Name: "catalog", Namespace: "namespace"}
+
+	subs := []*v1alpha1.Subscription{
+		newSub(catalog.Namespace, "a", "c", catalog),
+	}
+	logger, _ := test.NewNullLogger()
+	resolver := SatResolver{
+		cache: getFakeOperatorCache(NamespacedOperatorCache{
+			snapshots: map[registry.CatalogKey]*CatalogSnapshot{
+				catalog: {
+					key: catalog,
+					operators: []*Operator{
+						genOperator("a-1", "1.0.0", "", "a", "c", catalog.Name, catalog.Namespace, nil, nil, nil, "", false),
+						genOperator("a-2", "2.0.0", "a-1", "a", "c", catalog.Name, catalog.Namespace, nil, nil, nil, "", true),
+						genOperator("a-3", "3.0.0", "a-2", "a", "c", catalog.Name, catalog.Namespace, nil, nil, nil, "", false),
+					},
+				},
+			},
+		}),
+		log: logger,
+	}
+
+	operators, err := resolver.SolveOperators([]string{catalog.Namespace}, nil, subs)
+	assert.NoError(t, err)
+	assert.Len(t, operators, 1)
+	assert.Contains(t, operators, "a-3")
+}
+
+func TestSolveOperatorsWithDeprecatedStartingCSV(t *testing.T) {
+	catalog := registry.CatalogKey{Name: "catalog", Namespace: "namespace"}
+
+	subs := []*v1alpha1.Subscription{
+		newSub(catalog.Namespace, "a", "c", catalog, withStartingCSV("a-1")),
+	}
+	logger, _ := test.NewNullLogger()
+	resolver := SatResolver{
+		cache: getFakeOperatorCache(NamespacedOperatorCache{
+			snapshots: map[registry.CatalogKey]*CatalogSnapshot{
+				catalog: {
+					key: catalog,
+					operators: []*Operator{
+						genOperator("a-1", "1.0.0", "", "a", "c", catalog.Name, catalog.Namespace, nil, nil, nil, "", true),
+					},
+				},
+			},
+		}),
+		log: logger,
+	}
+
+	operators, err := resolver.SolveOperators([]string{catalog.Namespace}, nil, subs)
+	assert.NoError(t, err)
+	assert.Len(t, operators, 1)
+	assert.Contains(t, operators, "a-1")
+}
+
 func TestSolveOperators_WithSkipsAndStartingCSV(t *testing.T) {
 	APISet := APISet{opregistry.APIKey{"g", "v", "k", "ks"}: struct{}{}}
 	Provides := APISet