Bump k8s dependencies to 1.23 to align with o-f/api

- logr updated from v0.4.0 to v1.2.0 (cascading implications)
- Bumped to go 1.17 in Dockerfile
- Amended the github action for unit tests:
  - the envtest binaries were very very old (K8 1.16)
  - the distribution of kubebuilder binaries and envtest changed in the meantime
  - kubebuilder is not really needed for the tests and not part of the envtest installation ->  check disabled in Makefile
- Used `kubectl create` instead of `kubectl apply` to avoid too long annotations for CRDs

Signed-off-by: Frederic Giloux <[email protected]>

Author: fgiloux

.github/workflows/unit.yml

@@ -17,7 +17,9 @@ jobs:
         run: |
           os=$(go env GOOS)
           arch=$(go env GOARCH)
-          curl -L https://github.com/kubernetes-sigs/kubebuilder/releases/download/v2.3.1/kubebuilder_2.3.1_${os}_${arch}.tar.gz | tar -xz -C /tmp/
-          sudo mv /tmp/kubebuilder_2.3.1_${os}_${arch} /usr/local/kubebuilder
+          go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
+          setup-envtest use --use-env -p path 1.19.x!
+          sudo mkdir -p /usr/local/kubebuilder/bin
+          sudo cp /home/runner/.local/share/kubebuilder-envtest/k8s/1.19.2-linux-amd64/* /usr/local/kubebuilder/bin/
       - name: Run unit tests
         run: make unit

Dockerfile

@@ -5,7 +5,9 @@ WORKDIR /build
 # install dependencies and go 1.16
 
 # copy just enough of the git repo to parse HEAD, used to record version in OLM binaries
-RUN dnf update -y && dnf install -y bash make git mercurial jq wget golang && dnf upgrade -y
+RUN dnf update -y && dnf install -y bash make git mercurial jq wget && dnf upgrade -y
+RUN curl -sSL https://go.dev/dl/go1.17.6.linux-amd64.tar.gz | tar -xzf - -C /usr/local
+ENV PATH=/usr/local/go/bin:$PATH
 COPY .git/HEAD .git/HEAD
 COPY .git/refs/heads/. .git/refs/heads
 RUN mkdir -p .git/objects

Makefile

@@ -49,9 +49,10 @@ unit: kubebuilder
 # Ensure kubebuilder is installed before continuing
 KUBEBUILDER_ASSETS_ERR := not detected in $(KUBEBUILDER_ASSETS), to override the assets path set the KUBEBUILDER_ASSETS environment variable, for install instructions see https://book.kubebuilder.io/quick-start.html
 kubebuilder:
-ifeq (, $(wildcard $(KUBEBUILDER_ASSETS)/kubebuilder))
-	$(error kubebuilder $(KUBEBUILDER_ASSETS_ERR))
-endif
+# not needed for envtest
+# ifeq (, $(wildcard $(KUBEBUILDER_ASSETS)/kubebuilder))
+# 	$(error kubebuilder $(KUBEBUILDER_ASSETS_ERR))
+# endif
 ifeq (, $(wildcard $(KUBEBUILDER_ASSETS)/etcd))
 	$(error etcd $(KUBEBUILDER_ASSETS_ERR))
 endif

cmd/package-server/main.go

@@ -6,6 +6,7 @@ import (
 
 	log "github.com/sirupsen/logrus"
 	"k8s.io/component-base/logs"
+	"k8s.io/klog"
 
 	"github.com/operator-framework/operator-lifecycle-manager/pkg/lib/signals"
 	"github.com/operator-framework/operator-lifecycle-manager/pkg/package-server/server"
@@ -19,6 +20,11 @@ func main() {
 	options := server.NewPackageServerOptions(os.Stdout, os.Stderr)
 	cmd := server.NewCommandStartPackageServer(ctx, options)
 	cmd.Flags().AddGoFlagSet(flag.CommandLine)
+	// klog flags used by dependencies need to be explicitly initialized now
+	klogFlags := flag.NewFlagSet("klog", flag.ExitOnError)
+	klog.InitFlags(klogFlags)
+	cmd.Flags().AddGoFlagSet(klogFlags)
+
 	if err := cmd.Flags().Parse(flag.Args()); err != nil {
 		log.Fatal(err)
 	}

deploy/chart/crds/0000_50_olm_00-catalogsources.crd.yaml

@@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.6.2
+    controller-gen.kubebuilder.io/version: v0.8.0
   creationTimestamp: null
   name: catalogsources.operators.coreos.com
 spec:
@@ -145,7 +145,7 @@ spec:
                   description: Represents the state of a CatalogSource. Note that Message and Reason represent the original status information, which may be migrated to be conditions based in the future. Any new features introduced will use conditions.
                   type: array
                   items:
-                    description: "Condition contains details for one aspect of the current state of this API Resource. --- This struct is intended for direct use as an array at the field path .status.conditions.  For example, type FooStatus struct{     // Represents the observations of a foo's current state.     // Known .status.conditions.type are: \"Available\", \"Progressing\", and \"Degraded\"     // +patchMergeKey=type     // +patchStrategy=merge     // +listType=map     // +listMapKey=type     Conditions []metav1.Condition `json:\"conditions,omitempty\" patchStrategy:\"merge\" patchMergeKey:\"type\" protobuf:\"bytes,1,rep,name=conditions\"` \n     // other fields }"
+                    description: "Condition contains details for one aspect of the current state of this API Resource. --- This struct is intended for direct use as an array at the field path .status.conditions.  For example, type FooStatus struct{ // Represents the observations of a foo's current state. // Known .status.conditions.type are: \"Available\", \"Progressing\", and \"Degraded\" // +patchMergeKey=type // +patchStrategy=merge // +listType=map // +listMapKey=type Conditions []metav1.Condition `json:\"conditions,omitempty\" patchStrategy:\"merge\" patchMergeKey:\"type\" protobuf:\"bytes,1,rep,name=conditions\"` \n // other fields }"
                     type: object
                     required:
                       - lastTransitionTime