fix for should have deleted the dependent since both the owners were deleted

Author: bowenislandsong

test/e2e/gc_e2e_test.go

@@ -223,7 +223,7 @@ var _ = Describe("Dependant garbage collection", func() {
 			_, err = kubeClient.KubernetesInterface().CoreV1().ConfigMaps(testNamespace).Create(context.TODO(), dependent, metav1.CreateOptions{})
 			Expect(err).NotTo(HaveOccurred(), "dependent could not be created")
 
-			propagation = "Foreground"
+			propagation = metav1.DeletePropagationForeground
 			options = metav1.DeleteOptions{PropagationPolicy: &propagation}
 		})
 
@@ -238,7 +238,7 @@ var _ = Describe("Dependant garbage collection", func() {
 				Eventually(func() error {
 					_, err := operatorClient.OperatorsV1alpha1().ClusterServiceVersions(testNamespace).Get(context.TODO(), ownerA.GetName(), metav1.GetOptions{})
 					return err
-				}).ShouldNot(HaveOccurred())
+				}).Should(HaveOccurred())
 
 			})
 
@@ -262,7 +262,7 @@ var _ = Describe("Dependant garbage collection", func() {
 				Eventually(func() error {
 					_, err := operatorClient.OperatorsV1alpha1().ClusterServiceVersions(testNamespace).Get(context.TODO(), ownerA.GetName(), metav1.GetOptions{})
 					return err
-				}).ShouldNot(HaveOccurred())
+				}).Should(Equal(k8serrors.IsNotFound(err)))
 
 				// delete ownerB in the foreground (to ensure any "blocking" dependents are deleted before ownerB)
 				err = operatorClient.OperatorsV1alpha1().ClusterServiceVersions(testNamespace).Delete(context.TODO(), fetchedB.GetName(), options)
@@ -272,11 +272,11 @@ var _ = Describe("Dependant garbage collection", func() {
 				Eventually(func() error {
 					_, err := operatorClient.OperatorsV1alpha1().ClusterServiceVersions(testNamespace).Get(context.TODO(), ownerB.GetName(), metav1.GetOptions{})
 					return err
-				}).ShouldNot(HaveOccurred())
+				}).Should(Equal(k8serrors.IsNotFound(err)))
 			})
 
 			It("should have deleted the dependent since both the owners were deleted", func() {
-				_, err := kubeClient.KubernetesInterface().CoreV1().ConfigMaps(testNamespace).Get(context.TODO(), dependent.GetName(), metav1.GetOptions{})
+				cm, err := kubeClient.KubernetesInterface().CoreV1().ConfigMaps(testNamespace).Get(context.TODO(), dependent.GetName(), metav1.GetOptions{})
 				Expect(err).To(HaveOccurred())
 				Expect(k8serrors.IsNotFound(err)).To(BeTrue())
 				ctx.Ctx().Logf("dependent successfully garbage collected after both owners were deleted")