Fix stale content in configmap due to stale bundle image in the node

If the bundle is already present in the node, during the unpack process
the configmap may potentially use a stale bundle image. The default
setting for ImagePullPolicy is `IfNotPresent` and should be changed to
`Always`.

Signed-off-by: Vu Dinh <[email protected]>

Author: dinhxuanvu

pkg/controller/bundle/bundle_unpacker.go

@@ -106,9 +106,10 @@ func (c *ConfigMapUnpacker) job(cmRef *corev1.ObjectReference, bundlePath string
 							},
 						},
 						{
-							Name:    "pull",
-							Image:   bundlePath,
-							Command: []string{"/util/cpb", "/bundle"}, // Copy bundle content to its mount
+							Name:            "pull",
+							Image:           bundlePath,
+							ImagePullPolicy: "Always",
+							Command:         []string{"/util/cpb", "/bundle"}, // Copy bundle content to its mount
 							VolumeMounts: []corev1.VolumeMount{
 								{
 									Name:      "bundle",

pkg/controller/bundle/bundle_unpacker_test.go

@@ -226,9 +226,10 @@ func TestConfigMapUnpacker(t *testing.T) {
 											},
 										},
 										{
-											Name:    "pull",
-											Image:   bundlePath,
-											Command: []string{"/util/cpb", "/bundle"}, // Copy bundle content to its mount
+											Name:            "pull",
+											Image:           bundlePath,
+											ImagePullPolicy: "Always",
+											Command:         []string{"/util/cpb", "/bundle"}, // Copy bundle content to its mount
 											VolumeMounts: []corev1.VolumeMount{
 												{
 													Name:      "bundle",
@@ -382,9 +383,10 @@ func TestConfigMapUnpacker(t *testing.T) {
 											},
 										},
 										{
-											Name:    "pull",
-											Image:   bundlePath,
-											Command: []string{"/util/cpb", "/bundle"}, // Copy bundle content to its mount
+											Name:            "pull",
+											Image:           bundlePath,
+											ImagePullPolicy: "Always",
+											Command:         []string{"/util/cpb", "/bundle"}, // Copy bundle content to its mount
 											VolumeMounts: []corev1.VolumeMount{
 												{
 													Name:      "bundle",
@@ -577,9 +579,10 @@ func TestConfigMapUnpacker(t *testing.T) {
 											},
 										},
 										{
-											Name:    "pull",
-											Image:   bundlePath,
-											Command: []string{"/util/cpb", "/bundle"}, // Copy bundle content to its mount
+											Name:            "pull",
+											Image:           bundlePath,
+											ImagePullPolicy: "Always",
+											Command:         []string{"/util/cpb", "/bundle"}, // Copy bundle content to its mount
 											VolumeMounts: []corev1.VolumeMount{
 												{
 													Name:      "bundle",