fix: use server-side apply in crd e2e test when changing the subscription to point to a new channel to avoid transient object modified errors

Author: exdx

test/e2e/crd_e2e_test.go

@@ -5,6 +5,8 @@ import (
 	"fmt"
 	"time"
 
+	"k8s.io/apimachinery/pkg/types"
+
 	"github.com/blang/semver"
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
@@ -15,6 +17,7 @@ import (
 	apiextensionsv1beta1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1"
 	k8serrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
 var _ = Describe("CRD Versions", func() {
@@ -304,8 +307,21 @@ var _ = Describe("CRD Versions", func() {
 
 		// update channel on sub
 		sub.Spec.Channel = alphaChannel
-		_, err = crc.OperatorsV1alpha1().Subscriptions(testNamespace).Update(context.TODO(), sub, metav1.UpdateOptions{})
-		Expect(err).ToNot(HaveOccurred(), "could not update subscription")
+		sub.TypeMeta.APIVersion = "operators.coreos.com/v1alpha1"
+		sub.TypeMeta.Kind = "Subscription"
+		sub.ManagedFields = []metav1.ManagedFieldsEntry{}
+
+		// use server-side apply to apply the update to the subscription point to the alpha channel
+		forceApply := true
+		opts := metav1.PatchOptions{
+			Force:        &forceApply,
+			FieldManager: "operator-lifecycle-manager-registry-reconciler",
+		}
+		newSub, err := client.Apply.Data(sub)
+		Expect(err).ToNot(HaveOccurred(), "could not serialize updated subscription to bytes")
+
+		_, err = crc.OperatorsV1alpha1().Subscriptions(testNamespace).Patch(context.TODO(), sub.GetName(), types.ApplyPatchType, newSub, opts)
+		Expect(err).ToNot(HaveOccurred(), "could not patch subscription with updated channel")
 
 		subscriptionAtLatestWithDifferentInstallPlan := func(v *operatorsv1alpha1.Subscription) bool {
 			return subscriptionStateAtLatestChecker(v) && v.Status.InstallPlanRef != nil && v.Status.InstallPlanRef.Name != fetchedInstallPlan.Name