Skip to content

Commit fc58998

Browse files
author
Josef Karasek
committed
Move first metric check to BeforeEach()
Signed-off-by: Josef Karasek <[email protected]>
1 parent d881085 commit fc58998

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

test/e2e/metrics_e2e_test.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,19 +130,18 @@ var _ = Describe("Metrics are generated for OLM managed resources", func() {
130130

131131
_, err = fetchCSV(crc, csv.Name, testNamespace, csvSucceededChecker)
132132
Expect(err).ToNot(HaveOccurred())
133+
134+
Expect(getMetricsFromPod(c, getPodWithLabel(c, "app=olm-operator"), "8081")).To(
135+
ContainElement(LikeMetric(WithFamily("csv_succeeded"), WithName(csv.Name), WithValue(1))),
136+
)
133137
})
134138
AfterEach(func() {
135139
if cleanupCSV != nil {
136140
cleanupCSV()
137141
}
138142
})
139143
It("csv metric is preserved", func() {
140-
Expect(getMetricsFromPod(c, getPodWithLabel(c, "app=olm-operator"), "8081")).To(
141-
ContainElement(LikeMetric(WithFamily("csv_succeeded"), WithName(csv.Name), WithValue(1))),
142-
)
143-
144144
restartDeploymentWithLabel(c, "app=olm-operator")
145-
146145
Expect(getMetricsFromPod(c, getPodWithLabel(c, "app=olm-operator"), "8081")).To(
147146
ContainElement(LikeMetric(WithFamily("csv_succeeded"), WithName(csv.Name), WithValue(1))),
148147
)

0 commit comments

Comments
 (0)