Skip to content
This repository was archived by the owner on Nov 18, 2020. It is now read-only.

Refactor/controller runtime #38

Merged
merged 6 commits into from
Oct 19, 2018
Merged

Refactor/controller runtime #38

merged 6 commits into from
Oct 19, 2018

Conversation

AlexNPavel
Copy link
Contributor

No description provided.

@AlexNPavel AlexNPavel requested a review from hasbro17 October 19, 2018 22:42
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 19, 2018
@AlexNPavel AlexNPavel changed the base branch from refactor/controller-runtime to master October 19, 2018 22:49
@AlexNPavel AlexNPavel merged commit 60659ad into operator-framework:master Oct 19, 2018
@AlexNPavel AlexNPavel deleted the refactor/controller-runtime branch October 19, 2018 22:52
@hasbro17
Copy link
Contributor

@AlexNPavel We forgot to remove the unused files and folders from the older project before the refactor like tmp/build and deploy/sa.yaml.
https://github.com/operator-framework/operator-sdk-samples/tree/master/memcached-operator/tmp/build
We can remove those in a follow up PR.

2 similar comments
@hasbro17
Copy link
Contributor

@AlexNPavel We forgot to remove the unused files and folders from the older project before the refactor like tmp/build and deploy/sa.yaml.
https://github.com/operator-framework/operator-sdk-samples/tree/master/memcached-operator/tmp/build
We can remove those in a follow up PR.

@hasbro17
Copy link
Contributor

@AlexNPavel We forgot to remove the unused files and folders from the older project before the refactor like tmp/build and deploy/sa.yaml.
https://github.com/operator-framework/operator-sdk-samples/tree/master/memcached-operator/tmp/build
We can remove those in a follow up PR.

@AlexNPavel AlexNPavel mentioned this pull request Oct 22, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hasbro17 hasbro17 Awaiting requested review from hasbro17

Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexNPavel @hasbro17 @openshift-ci-robot