pkg/test/context.go: make NewTestCtx return ptr (#451)

AlexNPavel · web-flow · commit 408e7567e74f · 2018-08-31T15:04:31.000-07:00
diff --git a/pkg/test/context.go b/pkg/test/context.go
@@ -30,7 +30,7 @@ type TestCtx struct {
 
 type finalizerFn func() error
 
-func NewTestCtx(t *testing.T) TestCtx {
+func NewTestCtx(t *testing.T) *TestCtx {
 	var prefix string
 	if t != nil {
 		// TestCtx is used among others for namespace names where '/' is forbidden
@@ -48,7 +48,7 @@ func NewTestCtx(t *testing.T) TestCtx {
 	}
 
 	id := prefix + "-" + strconv.FormatInt(time.Now().Unix(), 10)
-	return TestCtx{
+	return &TestCtx{
 		ID: id,
 	}
 }
diff --git a/test/test-framework/memcached_test.go b/test/test-framework/memcached_test.go
@@ -51,7 +51,7 @@ func TestMemcached(t *testing.T) {
 	})
 }
 
-func memcachedScaleTest(t *testing.T, f *framework.Framework, ctx framework.TestCtx) error {
+func memcachedScaleTest(t *testing.T, f *framework.Framework, ctx *framework.TestCtx) error {
 	namespace, err := ctx.GetNamespace()
 	if err != nil {
 		return fmt.Errorf("could not get namespace: %v", err)

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ type TestCtx struct {`
`30`	`30`
`31`	`31`	`type finalizerFn func() error`
`32`	`32`
`33`		`-func NewTestCtx(t *testing.T) TestCtx {`
	`33`	`+func NewTestCtx(t testing.T) TestCtx {`
`34`	`34`	`var prefix string`
`35`	`35`	`if t != nil {`
`36`	`36`	`// TestCtx is used among others for namespace names where '/' is forbidden`
`@@ -48,7 +48,7 @@ func NewTestCtx(t *testing.T) TestCtx {`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`id := prefix + "-" + strconv.FormatInt(time.Now().Unix(), 10)`
`51`		`- return TestCtx{`
	`51`	`+ return &TestCtx{`
`52`	`52`	`ID: id,`
`53`	`53`	`}`
`54`	`54`	`}`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ func TestMemcached(t *testing.T) {`
`51`	`51`	`})`
`52`	`52`	`}`
`53`	`53`
`54`		`-func memcachedScaleTest(t testing.T, f framework.Framework, ctx framework.TestCtx) error {`
	`54`	`+func memcachedScaleTest(t testing.T, f framework.Framework, ctx *framework.TestCtx) error {`
`55`	`55`	`namespace, err := ctx.GetNamespace()`
`56`	`56`	`if err != nil {`
`57`	`57`	`return fmt.Errorf("could not get namespace: %v", err)`