Merge pull request #812 from mhrivnak/runner-output-on-failure

mhrivnak · web-flow · commit 5c2aaa04f12f · 2018-12-05T13:04:29.000-05:00
pkg/ansible/runner: logs the stdout and stderr from ansible-runner if…
diff --git a/pkg/ansible/runner/runner.go b/pkg/ansible/runner/runner.go
@@ -245,9 +245,9 @@ func (r *runner) Run(ident string, u *unstructured.Unstructured, kubeconfig stri
 			dc = r.cmdFunc(ident, inputDir.Path)
 		}
 
-		err := dc.Run()
+		output, err := dc.CombinedOutput()
 		if err != nil {
-			logger.Error(err, "error from ansible-runner")
+			logger.Error(err, string(output))
 		} else {
 			logger.Info("ansible-runner exited successfully")
 		}

Original file line number	Diff line number	Diff line change
`@@ -245,9 +245,9 @@ func (r runner) Run(ident string, u unstructured.Unstructured, kubeconfig stri`
`245`	`245`	`dc = r.cmdFunc(ident, inputDir.Path)`
`246`	`246`	`}`
`247`	`247`
`248`		`- err := dc.Run()`
	`248`	`+ output, err := dc.CombinedOutput()`
`249`	`249`	`if err != nil {`
`250`		`- logger.Error(err, "error from ansible-runner")`
	`250`	`+ logger.Error(err, string(output))`
`251`	`251`	`} else {`
`252`	`252`	`logger.Info("ansible-runner exited successfully")`
`253`	`253`	`}`