Add dev linter makefile target (#2254)

* Add dev linter makefile target (make lint)
* Refacootry lint script to have the dev and the ci ones that the dev one has all checks and then, the ci just that ones that we could solve the issues already.

Author: camilamacedo86

.travis.yml

@@ -125,16 +125,16 @@ jobs:
       name: Subcommands on Kubernetes
       script: make test-subcommand
 
-    # Run the unit, sanity, markdown, coverage and linter tests
+    # Run the unit, sanity and markdown tests
     - stage: test
       name: Unit, Sanity, and Markdown Tests
       before_install:
         - go get github.com/mattn/goveralls
       script:
-        - make test-sanity test-unit test-markdown test-linter
+        - make test-sanity test-unit test-markdown
         - $GOPATH/bin/goveralls -service=travis-ci -coverprofile=coverage.out -repotoken=$COVERALLS_TOKEN
       after_success: echo 'Tests Passed'
-      after_failure: echo 'Failure in unit, sanity, markdown, coverage or linter test'
+      after_failure: echo 'Failure in unit, sanity and markdown tests'
 
     # Build and deploy ansible-operator docker image
     - <<: *deploy

Makefile

@@ -58,7 +58,7 @@ install: ## Build & install the Operator SDK CLI binary
 		$(BUILD_PATH)
 
 # Code management.
-.PHONY: format tidy clean cli-doc
+.PHONY: format tidy clean cli-doc lint
 
 format: ## Format the source code
 	$(Q)go fmt $(PKGS)
@@ -69,6 +69,9 @@ tidy: ## Update dependencies
 clean: ## Clean up the build artifacts
 	$(Q)rm -rf build
 
+lint:  ## Run golangci-lint with all checks enabled (development purpose only)
+	./hack/tests/check-lint.sh dev
+
 ##############################
 # Generate Artifacts         #
 ##############################
@@ -170,18 +173,16 @@ image-push-scorecard-proxy:
 ##@ Tests
 
 # Static tests.
-.PHONY: test test-markdown test-sanity test-unit test-linter
+.PHONY: test test-markdown test-sanity test-unit
 
 test: test-unit ## Run the tests
 
-test-linter:  ## Run golangci-lint for the project
-	./hack/go-linter.sh
-
 test-markdown test/markdown:
 	./hack/ci/marker
 
 test-sanity test/sanity: tidy build/operator-sdk
 	./hack/tests/sanity-check.sh
+	./hack/tests/check-lint.sh ci
 
 TEST_PKGS:=$(shell go list ./... | grep -v -P 'github.com/operator-framework/operator-sdk/(hack|test/e2e)')
 test-unit test/unit: ## Run the unit tests

hack/go-linter.sh

@@ -0,0 +1,48 @@
+#!/usr/bin/env bash
+set -e
+
+source ./hack/common.sh
+
+DEV_LINTERS=(
+    ##todo(camilamacedo86): The following checks requires fixes in the code.
+    ##todo(camilamacedo86): they should be enabled and added in the CI
+    "--enable=golint"
+    "--enable=gocyclo"
+    "--enable=lll"
+    "--enable=gosec"  # NOT add this one to CI since was defined that it should be optional for now at least.
+)
+
+subcommand=$1
+case $subcommand in
+	"dev")
+	  ##todo(camilamacedo86): It should be removed when all linter checks be enabled
+	  header_text "Checking the project with all linters (dev)"
+		LINTERS=${DEV_LINTERS[@]}
+		;;
+	"ci")
+	  header_text "Checking the project with the linters enabled for the ci"
+		;;
+	*)
+		echo "Must pass 'dev' or 'ci' argument"
+		exit 1
+esac
+
+fetch_go_linter
+
+header_text "Running golangci-lint"
+golangci-lint run --disable-all \
+    --deadline 5m \
+    --enable=nakedret \
+    --enable=interfacer \
+    --enable=varcheck \
+    --enable=deadcode \
+    --enable=structcheck \
+    --enable=misspell \
+    --enable=maligned \
+    --enable=ineffassign \
+    --enable=goconst \
+    --enable=goimports \
+    --enable=errcheck \
+    --enable=dupl \
+    --enable=unparam \
+    ${LINTERS[@]}