Skip to content

Commit 7f00ede

Browse files
mhrivnakhasbro17
authored andcommitted
fully-qualifies example image, to support non-docker runtimes (#524)
Non-docker runtimes may not assume a particular registry. The CRI avoids such assumptions, leaving it up to individual runtimes. CRI-O as one runtime example does not assume docker.io. This change can be tested with cri-o on minikube with a command similar to: `minikube start --kubernetes-version=v1.11.3 --network-plugin=cni --container-runtime=cri-o`
1 parent 72431e2 commit 7f00ede

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

pkg/generator/generator_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ func newbusyBoxPod(cr *v1alpha1.AppService) *corev1.Pod {
139139
Containers: []corev1.Container{
140140
{
141141
Name: "busybox",
142-
Image: "busybox",
142+
Image: "docker.io/busybox",
143143
Command: []string{"sleep", "3600"},
144144
},
145145
},

pkg/generator/templates.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ func newbusyBoxPod(cr *{{.Version}}.{{.Kind}}) *corev1.Pod {
230230
Containers: []corev1.Container{
231231
{
232232
Name: "busybox",
233-
Image: "busybox",
233+
Image: "docker.io/busybox",
234234
Command: []string{"sleep", "3600"},
235235
},
236236
},

0 commit comments

Comments
 (0)