pkg/helm/release/manager.go: don't do atomic releases

Author: joelanford

pkg/helm/release/manager.go

@@ -176,18 +176,55 @@ func (m manager) InstallRelease(ctx context.Context) (*rpb.Release, error) {
 	install := action.NewInstall(m.actionConfig)
 	install.ReleaseName = m.releaseName
 	install.Namespace = m.namespace
-	install.Atomic = true
-	return install.Run(m.chart, m.values)
+
+	installedRelease, err := install.Run(m.chart, m.values)
+	if err != nil {
+		// Workaround for helm/helm#3338
+		if installedRelease != nil {
+			uninstall := action.NewUninstall(m.actionConfig)
+			_, uninstallErr := uninstall.Run(m.releaseName)
+
+			// In certain cases, InstallRelease will return a partial release in
+			// the response even when it doesn't record the release in its release
+			// store (e.g. when there is an error rendering the release manifest).
+			// In that case the rollback will fail with a not found error because
+			// there was nothing to rollback.
+			//
+			// Only log a message about a rollback failure if the failure was caused
+			// by something other than the release not being found.
+			if uninstallErr != nil && !notFoundErr(uninstallErr) {
+				return nil, fmt.Errorf("failed installation (%s) and failed rollback (%s)", err, uninstallErr)
+			}
+		}
+		return nil, fmt.Errorf("failed to install release: %s", err)
+	}
+	return installedRelease, nil
 }
 
 // UpdateRelease performs a Helm release update.
 func (m manager) UpdateRelease(ctx context.Context) (*rpb.Release, *rpb.Release, error) {
 	upgrade := action.NewUpgrade(m.actionConfig)
 	upgrade.Namespace = m.namespace
-	upgrade.Atomic = true
-	upgrade.CleanupOnFail = true
-	updatedRelease, err := upgrade.Run(m.releaseName, m.chart, m.values)
 
+	updatedRelease, err := upgrade.Run(m.releaseName, m.chart, m.values)
+	if err != nil {
+		// Workaround for helm/helm#3338
+		if updatedRelease != nil {
+			rollback := action.NewRollback(m.actionConfig)
+			rollback.Force = true
+
+			// As of Helm 2.13, if UpdateRelease returns a non-nil release, that
+			// means the release was also recorded in the release store.
+			// Therefore, we should perform the rollback when we have a non-nil
+			// release. Any rollback error here would be unexpected, so always
+			// log both the update and rollback errors.
+			rollbackErr := rollback.Run(m.releaseName)
+			if rollbackErr != nil {
+				return nil, nil, fmt.Errorf("failed update (%s) and failed rollback (%s)", err, rollbackErr)
+			}
+		}
+		return nil, nil, fmt.Errorf("failed to update release: %s", err)
+	}
 	return m.deployedRelease, updatedRelease, err
 }