Changed log.info to tidy up using fmt.sprintf (#2246)

getIntegerEnvWithDefault  func added to return value for MaxWorkers/Ansibleverbosity based on if envVar is set or a defvalue is used

Author: bharathi-tenneti

CHANGELOG.md

@@ -25,6 +25,7 @@
 ### Removed
 
 ### Bug Fixes
+- Fixed log formatting issue that occurred while loading the configuration for Ansible-based operators. ([#2246](https://github.com/operator-framework/operator-sdk/pull/2246))
 - Fix issue faced in the Ansible based operators when `jmespath` queries are used because it was not installed. ([#2252](https://github.com/operator-framework/operator-sdk/pull/2252))
 - Updates `operator-sdk build` for go operators to compile the operator binary based on Go's built-in GOARCH detection. This fixes an issue that caused an `amd64` binary to be built into non-`amd64` base images when using operator-sdk on non-`amd64` architectures. ([#2268](https://github.com/operator-framework/operator-sdk/pull/2268))
 - Fix scorecard behavior such that a CSV file is read correctly when `olm-deployed` is set to `true`. ([#2274](https://github.com/operator-framework/operator-sdk/pull/2274))

pkg/ansible/watches/watches.go

@@ -272,13 +272,7 @@ func getMaxWorkers(gvk schema.GroupVersionKind, defValue int) int {
 		"_",
 		-1,
 	))
-	maxWorkers, err := strconv.Atoi(os.Getenv(envVar))
-	if err != nil {
-		// we don't care why we couldn't parse it just use default
-		log.Info("Failed to parse %v from environment. Using default %v", envVar, defValue)
-		return defValue
-	}
-
+	maxWorkers := getIntegerEnvWithDefault(envVar, defValue)
 	if maxWorkers <= 0 {
 		log.Info("Value %v not valid. Using default %v", maxWorkers, defValue)
 		return defValue
@@ -295,12 +289,7 @@ func getAnsibleVerbosity(gvk schema.GroupVersionKind, defValue int) int {
 		"_",
 		-1,
 	))
-	ansibleVerbosity, err := strconv.Atoi(os.Getenv(envVar))
-	if err != nil {
-		log.Info("Failed to parse %v from environment. Using default %v", envVar, defValue)
-		return defValue
-	}
-
+	ansibleVerbosity := getIntegerEnvWithDefault(envVar, defValue)
 	// Use default value when value doesn't make sense
 	if ansibleVerbosity < 0 {
 		log.Info("Value %v not valid. Using default %v", ansibleVerbosity, defValue)
@@ -312,3 +301,18 @@ func getAnsibleVerbosity(gvk schema.GroupVersionKind, defValue int) int {
 	}
 	return ansibleVerbosity
 }
+
+// getIntegerEnvWithDefault returns value for MaxWorkers/Ansibleverbosity based on if envVar is set or a defvalue is used.
+func getIntegerEnvWithDefault(envVar string, defValue int) int {
+	val := defValue
+	if envVal, ok := os.LookupEnv(envVar); ok {
+		if i, err := strconv.Atoi(envVal); err != nil {
+			log.Info("Could not parse environment variable as an integer; using default value", "envVar", envVar, "default", defValue)
+		} else {
+			val = i
+		}
+	} else if !ok {
+		log.Info("Environment variable not set; using default value", "envVar", envVar, "default", defValue)
+	}
+	return val
+}