Skip to content

Commit a4618dd

Browse files
committed
Gopkg.toml: kubernetes 1.12.2
pkg/helm/release/manager*.go: fix broken API's from k8s upgrade
1 parent 7c77ded commit a4618dd

File tree

3 files changed

+28
-24
lines changed

3 files changed

+28
-24
lines changed

Gopkg.toml

Lines changed: 21 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,46 +1,50 @@
1-
[[constraint]]
2-
name = "github.com/sirupsen/logrus"
3-
version = "1.0.4"
4-
5-
[[constraint]]
6-
name = "github.com/spf13/cobra"
7-
version = "0.0.3"
1+
[[override]]
2+
name = "k8s.io/kubernetes"
3+
version = "=1.12.2"
84

95
[[override]]
106
name = "k8s.io/api"
11-
version = "kubernetes-1.11.2"
7+
version = "kubernetes-1.12.2"
128

139
[[override]]
1410
name = "k8s.io/apimachinery"
15-
version = "kubernetes-1.11.2"
11+
version = "kubernetes-1.12.2"
1612

1713
[[override]]
1814
name = "k8s.io/apiextensions-apiserver"
19-
version = "kubernetes-1.11.2"
15+
version = "kubernetes-1.12.2"
2016

2117
[[override]]
2218
name = "k8s.io/apiserver"
23-
version = "kubernetes-1.11.2"
19+
version = "kubernetes-1.12.2"
2420

2521
[[override]]
2622
name = "k8s.io/client-go"
27-
version = "kubernetes-1.11.2"
23+
version = "kubernetes-1.12.2"
24+
25+
[[override]]
26+
name = "k8s.io/cli-runtime"
27+
version = "kubernetes-1.12.2"
2828

2929
[[constraint]]
3030
name = "github.com/sergi/go-diff"
3131
version = "1.0.0"
3232

3333
[[constraint]]
3434
name = "sigs.k8s.io/controller-runtime"
35-
version = "v0.1.4"
35+
revision = "a4051585e748b437e799d597f9adba1d777cb12a"
3636

3737
[[constraint]]
3838
name = "k8s.io/helm"
39-
version = "2.11.0"
39+
version = "=2.12.0-rc.1"
4040

41-
[[override]]
42-
name = "k8s.io/kubernetes"
43-
version = "=1.11.2"
41+
[[constraint]]
42+
name = "github.com/sirupsen/logrus"
43+
version = "1.0.4"
44+
45+
[[constraint]]
46+
name = "github.com/spf13/cobra"
47+
version = "0.0.3"
4448

4549
# We need overrides for the following imports because dep can't resolve them
4650
# correctly. The easiest way to get this right is to use the versions that
@@ -56,4 +60,3 @@
5660
[[override]]
5761
name = "github.com/docker/docker"
5862
revision = "4f3616fb1c112e206b88cb7a9922bf49067a7756"
59-

pkg/helm/release/manager.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@ import (
2424

2525
yaml "gopkg.in/yaml.v2"
2626
apierrors "k8s.io/apimachinery/pkg/api/errors"
27+
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2728
apitypes "k8s.io/apimachinery/pkg/types"
29+
"k8s.io/cli-runtime/pkg/genericclioptions/resource"
2830
"k8s.io/client-go/rest"
2931
"k8s.io/helm/pkg/chartutil"
3032
"k8s.io/helm/pkg/kube"
@@ -33,7 +35,6 @@ import (
3335
"k8s.io/helm/pkg/proto/hapi/services"
3436
"k8s.io/helm/pkg/storage"
3537
"k8s.io/helm/pkg/tiller"
36-
"k8s.io/kubernetes/pkg/kubectl/genericclioptions/resource"
3738

3839
"github.com/operator-framework/operator-sdk/pkg/helm/internal/types"
3940
)
@@ -310,7 +311,7 @@ func reconcileRelease(ctx context.Context, tillerKubeClient *kube.Client, namesp
310311
*r = *r.Context(ctx)
311312
})
312313
helper := resource.NewHelper(expectedClient, expected.Mapping)
313-
_, err = helper.Create(expected.Namespace, true, expected.Object)
314+
_, err = helper.Create(expected.Namespace, true, expected.Object, &metav1.CreateOptions{})
314315
if err == nil {
315316
return nil
316317
}
@@ -323,7 +324,7 @@ func reconcileRelease(ctx context.Context, tillerKubeClient *kube.Client, namesp
323324
return fmt.Errorf("failed to marshal JSON patch: %s", err)
324325
}
325326

326-
_, err = helper.Patch(expected.Namespace, expected.Name, apitypes.MergePatchType, patch)
327+
_, err = helper.Patch(expected.Namespace, expected.Name, apitypes.MergePatchType, patch, &metav1.UpdateOptions{})
327328
if err != nil {
328329
return fmt.Errorf("patch error: %s", err)
329330
}

pkg/helm/release/manager_factory.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@ import (
2424
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2525
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
2626
apitypes "k8s.io/apimachinery/pkg/types"
27+
clientset "k8s.io/client-go/kubernetes"
2728
helmengine "k8s.io/helm/pkg/engine"
2829
"k8s.io/helm/pkg/kube"
2930
"k8s.io/helm/pkg/storage"
3031
"k8s.io/helm/pkg/tiller"
3132
"k8s.io/helm/pkg/tiller/environment"
32-
"k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset"
3333

3434
"github.com/operator-framework/operator-sdk/pkg/helm/engine"
3535
"github.com/operator-framework/operator-sdk/pkg/helm/internal/types"
@@ -86,9 +86,9 @@ func (f managerFactory) tillerRendererForCR(r *unstructured.Unstructured) *tille
8686
KubeClient: f.tillerKubeClient,
8787
}
8888
kubeconfig, _ := f.tillerKubeClient.ToRESTConfig()
89-
internalClientSet, _ := internalclientset.NewForConfig(kubeconfig)
89+
cs := clientset.NewForConfigOrDie(kubeconfig)
9090

91-
return tiller.NewReleaseServer(env, internalClientSet, false)
91+
return tiller.NewReleaseServer(env, cs, false)
9292
}
9393

9494
func getReleaseName(r *unstructured.Unstructured) string {

0 commit comments

Comments
 (0)