commands/.../scorecard: fix unit test

Author: AlexNPavel

commands/operator-sdk/cmd/scorecard/test_definitions.go

@@ -267,6 +267,7 @@ func NewOLMTestSuite(conf OLMTestConfig) *TestSuite {
 		"Test suite checks if an operator's CSV follows best practices",
 	)
 
+	ts.AddTest(NewCRDsHaveValidationTest(conf), 24)
 	ts.AddTest(NewCRDsHaveResourcesTest(conf), 19)
 	ts.AddTest(NewAnnotationsContainExamplesTest(conf), 19)
 	ts.AddTest(NewSpecDescriptorsTest(conf), 19)

commands/operator-sdk/cmd/scorecard/test_definitions_test.go

@@ -19,15 +19,17 @@ import "testing"
 // TestSuiteWeightsCheck makes sure that the combined weights of all
 // the tests in a suite adds up to 100
 func TestSuiteWeightsCheck(t *testing.T) {
+	basicTests := NewBasicTestSuite(BasicTestConfig{})
 	basicWeight := 0
-	for _, weight := range BasicTests.weights {
+	for _, weight := range basicTests.Weights {
 		basicWeight += weight
 	}
 	if basicWeight != 100 {
 		t.Errorf("Weights of Basic Tests add to %d", basicWeight)
 	}
+	olmTests := NewOLMTestSuite(OLMTestConfig{})
 	OLMWeight := 0
-	for _, weight := range OLMTests.weights {
+	for _, weight := range olmTests.Weights {
 		OLMWeight += weight
 	}
 	if OLMWeight != 100 {

hack/tests/scorecard-subcommand.sh

@@ -18,11 +18,11 @@ commandoutput="$(operator-sdk scorecard \
   --proxy-image "$DEST_IMAGE" \
   --proxy-pull-policy Never \
   2>&1)"
-echo $commandoutput | grep "Total Score: 69%"
+echo $commandoutput | grep "Total Score: 81%"
 
 # test config file
 commandoutput2="$(operator-sdk scorecard \
   --proxy-image "$DEST_IMAGE" \
   --config "$CONFIG_PATH")"
-echo $commandoutput2 | grep "Total Score: 69%"
+echo $commandoutput2 | grep "Total Score: 81%"
 popd