Skip to content

Update uclient.go #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2019
Merged

Update uclient.go #2160

merged 1 commit into from
Nov 7, 2019

Conversation

fengxsong
Copy link
Contributor

DirectCodecFactory was renamed to WithoutConversionCodecFactory

Description of the change:
DirectCodecFactory was renamed to WithoutConversionCodecFactory in 1.15 and was removed in 1.16

Motivation for the change:

@fengxsong
Update uclient.go
f0c051b 
DirectCodecFactory was renamed to WithoutConversionCodecFactory
@openshift-ci-robot
Copy link

Hi @fengxsong. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2019
camilamacedo86
camilamacedo86 approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR 🥇.

Confirmed its motivation. See here

Also, it shows part of the k8s mod migration then IMHO has not required CHANGELOG and/or docs.

/ok-to-test
/lgtm /approved when pass in the CI

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2019
joelanford
joelanford approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joelanford joelanford merged commit 36b6de4 into operator-framework:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@jmrodri jmrodri Awaiting requested review from jmrodri

Assignees
No one assigned
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fengxsong @openshift-ci-robot @joelanford @camilamacedo86