Skip to content

fix(linter) : Add unparam checks and fix issues #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 5, 2019
Merged

fix(linter) : Add unparam checks and fix issues #2207

merged 4 commits into from
Dec 5, 2019

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Nov 17, 2019 •
edited
Loading

Description of the change:

  • Enable unparam check
  • Fix linter issues

Motivation
Closes: #2212

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 17, 2019
@camilamacedo86 camilamacedo86 changed the title Linter fix unparam fix(linter) : Add unparam checks and fix issues Nov 17, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2019
@camilamacedo86 camilamacedo86 added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. refactoring labels Nov 17, 2019
@camilamacedo86 camilamacedo86 mentioned this pull request Nov 17, 2019
Merged
@camilamacedo86 camilamacedo86 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 18, 2019
@camilamacedo86
Copy link
Contributor Author

/hold
(it is done and OK to go, the hold is just for we prioritize orders reviews )

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2019
@camilamacedo86 camilamacedo86 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2019
@camilamacedo86 camilamacedo86 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
jmrodri
jmrodri approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019
@jmrodri
Copy link
Member

jmrodri commented Dec 5, 2019

These were excellent finds by the linter.

@camilamacedo86 camilamacedo86 merged commit d147bb3 into operator-framework:master Dec 5, 2019
@camilamacedo86 camilamacedo86 deleted the linter-fix-unparam branch December 5, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@asmacdo asmacdo asmacdo approved these changes

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

@joelanford joelanford Awaiting requested review from joelanford

@fabianvf fabianvf Awaiting requested review from fabianvf

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

Assignees

@jmrodri jmrodri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable linter unparam and fix issues
4 participants
@camilamacedo86 @jmrodri @asmacdo @openshift-ci-robot