.travis.tml,hack/check_license.sh: add license header checks #381
Conversation
| - go test ./test/e2e/... | ||
| - go vet ./... | ||
| - ./hack/check_license.sh |
There was a problem hiding this comment.
I think we should do format check before any tests. In that way, we fail fast on any format issue. maybe move go vet ./... and ./hack/check_license.sh above line 34?
There was a problem hiding this comment.
Travis runs every line in the script section, even if one of the early ones fails: https://docs.travis-ci.com/user/customizing-the-build/#customizing-the-build-step
There was a problem hiding this comment.
Do you think we should put it in before_script? That way it should fail before doing any of the other tests.
There was a problem hiding this comment.
Travis runs every line in the script section, even if one of the early ones fails: Good find.
I don't really want to add fmt check to before_script script. This might be confusing what needs to be in before_script and in script. I think we should just keep it as it it now util travis add the fail fast feature. travis-ci/travis-ci#1066. Not sure what's going with travis, this feature has been requested for past 5 years. lol.
|
lgtm |
|
LGTM |
Fixes #379