internal/*: define ImageVersion, which is set to the most recent #4083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
commented
Oct 22, 2020
| var ( | ||
| Version = "unknown" | ||
| GitVersion = "unknown" | ||
| GitCommit = "unknown" | ||
| KubernetesVersion = "unknown" | ||
| GoVersion = fmt.Sprintf("%s %s/%s", runtime.Version(), runtime.GOOS, runtime.GOARCH) |
There was a problem hiding this comment.
GoVersion contains redundant information (GOOS and GOARCH are already printed by the version subcommand) so I removed it in favor of calling runtime.Version() directly.
|
Relates to #4061 |
camilamacedo86
approved these changes
Oct 30, 2020
There was a problem hiding this comment.
Hi @estroz,
Could you please rebase it with the master and push to re-trigger the tests?
It shows fine for me 👍 .
of operator-sdk repo tag or release commit's future tag. This variable is consumed by ansible-operator, helm-operator, and scorecard plugins Makefile: set IMAGE_VERSION to v1.1.0, and set ImageVersion in ldflags internal/version: removed GoVersion in favor of using runtime.Version() in dependent packages
estroz
force-pushed
the
feature/external-image-version
branch
from
df82397 to
cc5d27e
Compare
estroz
changed the title
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…rator-framework#4083) of operator-sdk repo tag or release commit's future tag. This variable is consumed by ansible-operator, helm-operator, and scorecard plugins Makefile: set IMAGE_VERSION to v1.1.0, and set ImageVersion in ldflags internal/version: removed GoVersion in favor of using runtime.Version() in dependent packages Signed-off-by: reinvantveer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: samples generated for a release commit will have incorrect versions, specifically the major+minor version preceding the soon-to-be-released version, in the current release setup because these versions depend on a release's git tag which has not been created yet. Setting this version explicitly in the Makefile breaks this cycle, allowing samples to be generated with a version that has not been released yet; these will still pass e2e tests because image tags are substituted anyway.
This PR makes no user-facing changes (except changing the
operator-sdk versionoutput string, which I would consider a bugfix and can add a fragment if desired).Closes #4061
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs